Skip to content

cnf network: added reportportal#80820

Open
kononovn wants to merge 1 commit into
openshift:mainfrom
kononovn:net_reporter
Open

cnf network: added reportportal#80820
kononovn wants to merge 1 commit into
openshift:mainfrom
kononovn:net_reporter

Conversation

@kononovn

@kononovn kononovn commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR adds ReportPortal integration to the CNF network functional test reporting pipeline in the eco-ci-cd repository.

Configuration Updates:
The CNF network phase 2 test configuration has been extended with ReportPortal-specific settings:

  • METRICS_LIST: general_ocp,sriov,ptp,fec,local_storage - specifies which metrics to collect and report
  • REPORTER_LAUNCH_NAME: telco-ft-net-core - identifies the test launch in ReportPortal
  • REPORTER_TEMPLATE_NAME - provides the report template format for ReportPortal with version and build information
  • REPORTPORTAL_FILES: .reportportal_url_Net_core - configuration file containing ReportPortal URL

The test post-processing pipeline was also updated to reference the new telcov10n-functional-report step, consolidating the reporting logic.

Reporting Script Enhancement:
The functional report command script now collects both polarion_*.xml and report_*.xml files from the job's shared directory and consolidates them into /tmp/reports. This expanded file collection allows test results to be uploaded to both Polarion and ReportPortal through the updated ansible playbook in the eco-ci-cd repository.

The changes enable automated test result tracking and reporting for CNF network core functional tests in the OpenShift CI infrastructure, providing better visibility into test execution and failure tracking across ReportPortal.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 56f5474d-0ba3-4f79-89ba-78c10f9c7294

📥 Commits

Reviewing files that changed from the base of the PR and between 4cb59c5 and 0248c25.

📒 Files selected for processing (2)
  • ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-network-phase2-5.0.yaml
  • ci-operator/step-registry/telcov10n/functional/report/telcov10n-functional-report-commands.sh

Walkthrough

The CNF network phase2 5.0 CI config gains three new reporter-related env vars (METRICS_LIST, REPORTER_LAUNCH_NAME, REPORTPORTAL_FILES) and switches its post reporter step to telcov10n-functional-report. The shared report commands script adds a loop to collect and rename report_*.xml files from SHARED_DIR into /tmp/reports.

Changes

CNF Network Reporter Configuration and Script Update

Layer / File(s) Summary
CNF network CI config: reporter env vars and post step
ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-network-phase2-5.0.yaml
Adds METRICS_LIST, REPORTER_LAUNCH_NAME, and REPORTPORTAL_FILES to the test env block; replaces the post reporter reference from telcov10n-functional-cnf-network-cnf-reporter to telcov10n-functional-report.
Functional report script: report_*.xml collection
ci-operator/step-registry/telcov10n/functional/report/telcov10n-functional-report-commands.sh
Adds a loop that iterates over report_*.xml files in SHARED_DIR, strips the report_ prefix, and copies them into /tmp/reports, guarded by an existence check.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • openshift/release#80810: Directly modifies REPORTER_TEMPLATE_NAME in the same openshift-kni-eco-ci-cd-main__cnf-network-phase2-5.0.yaml file, making it closely related to the reporter wiring changes in this PR.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • mkochanowski
  • cplacani
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'cnf network: added reportportal' directly reflects the main change—adding reportportal configuration to the CNF network test setup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration (YAML) and reporting script (bash) files, not Ginkgo test definitions. The check is not applicable.
Test Structure And Quality ✅ Passed PR contains only YAML configuration and shell scripts, not Ginkgo test code. The check is not applicable to this PR.
Microshift Test Compatibility ✅ Passed PR adds CI configuration and reporting scripts only; no new Ginkgo e2e tests are present, so MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests. Changes are limited to CI operator config (YAML) and shell reporting scripts, neither containing test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI configuration and test scripts, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML config and shell script files; no OTE binary code present. The check is not applicable to CI/CD configuration and shell script files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. Changes are limited to CI/CD configuration (YAML) and test reporting scripts (bash), not test code.
No-Weak-Crypto ✅ Passed The pull request changes configuration and file handling logic without introducing any weak cryptographic practices, custom crypto implementations, or insecure secret comparisons.
Container-Privileges ✅ Passed The PR modifies CI/CD configuration and a shell script. No Kubernetes manifests or container security specifications (privileged, hostPID, hostNetwork, hostIPC, allowPrivilegeEscalation, SYS_ADMIN,...
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data (passwords, tokens, API keys, PII, session IDs) exposed in logging statements. Only cluster names and metrics data are logged, which are non-sensitive.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kononovn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from mkochanowski and sosiouxme June 22, 2026 07:51
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@kononovn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.21-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.16-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ptp-sno-4.22-cnf-ran-ptp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.14-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ptp-sno-4.20-cnf-ran-ptp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.18-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.20-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-two-sno-4.22-cnf-ran-ztp-tests N/A periodic Registry content changed

The following jobs are not rehearsable without the network-access-rehearsals-ok, and approved labels present on this PR. This is due to the restrict_network_access field being set to false. The network-access-rehearsals-ok label can be added by any openshift org member other than the PR's author by commenting: /pj-rehearse network-access-allowed:

Test name
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-network-phase2-5.0-cnf-network-functional-tests

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@kononovn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant