OCPNODE-4055: Allow missing architectures for Additional Storage test images

[BhargaviGudi]

Summary

Add architecture exceptions for Additional Storage Support test images to the verify-image-manifest-lists presubmit job.

Background

PR openshift/origin#31083 introduces comprehensive E2E tests for the Additional Storage Support feature (OCPNODE-4055). The tests use three eStargz-format images for testing lazy-pulling functionality:

• quay.io/openshifttest/additional-storage-tests:test-5mb-estargz
• quay.io/openshifttest/additional-storage-tests:test-6gb-estargz-v1.0
• quay.io/openshifttest/additional-storage-tests:test-6gb-standard-v1.0

Issue

These images are currently amd64-only and fail the verify-image-manifest-lists CI check with:
error: the following images do not have manifest lists with all required architectures (amd64, arm64, ppc64le, s390x):
...test-5mb-estargz...: is not a manifest list
...test-6gb-estargz-v1.0...: is not a manifest list
...test-6gb-standard-v1.0...: is not a manifest list

Solution

Add these images to the --allow-missing-architectures exception list in the verify job configuration.

Changes

• Added 3 --allow-missing-architectures flags for the test images in ci-operator/config/openshift/origin/openshift-origin-main.yaml

Summary by CodeRabbit

This PR modifies the CI configuration for openshift/origin to accommodate three new test images required by the Additional Storage Support feature (OCPNODE-4055). Specifically, it adds architecture exceptions to the verify-image-manifest-lists presubmit check in the openshift/release repository.

What changed:
Three --allow-missing-architectures flags were added to the verify-image-manifest-lists test step in ci-operator/config/openshift/origin/openshift-origin-main.yaml. These exceptions allow the following eStargz-format test images to pass CI checks despite being amd64-only:

• quay.io/openshifttest/additional-storage-tests:test-5mb-estargz
• quay.io/openshifttest/additional-storage-tests:test-6gb-estargz-v1.0
• quay.io/openshifttest/additional-storage-tests:test-6gb-standard-v1.0

Why it matters:
The verify-image-manifest-lists check normally requires images to have manifest lists for all architectures (amd64, arm64, ppc64le, s390x). These test images are intentionally amd64-only for testing lazy-pulling functionality, so this exception is necessary to allow the E2E tests to run without CI failures. This change enables the upstream implementation of the Additional Storage Support feature while keeping test infrastructure focused on the specific architectures where testing is needed.

[openshift-ci-robot]

@BhargaviGudi: This pull request references OCPNODE-4055 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add architecture exceptions for Additional Storage Support test images to the verify-image-manifest-lists presubmit job.

Background

PR openshift/origin#31083 introduces comprehensive E2E tests for the Additional Storage Support feature (OCPNODE-4055). The tests use three eStargz-format images for testing lazy-pulling functionality:

• quay.io/openshifttest/additional-storage-tests:test-5mb-estargz
• quay.io/openshifttest/additional-storage-tests:test-6gb-estargz-v1.0
• quay.io/openshifttest/additional-storage-tests:test-6gb-standard-v1.0

Issue

These images are currently amd64-only and fail the verify-image-manifest-lists CI check with:
error: the following images do not have manifest lists with all required architectures (amd64, arm64, ppc64le, s390x):
...test-5mb-estargz...: is not a manifest list
...test-6gb-estargz-v1.0...: is not a manifest list
...test-6gb-standard-v1.0...: is not a manifest list

Solution

Add these images to the --allow-missing-architectures exception list in the verify job configuration.

Changes

• Added 3 --allow-missing-architectures flags for the test images in ci-operator/config/openshift/origin/openshift-origin-main.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BhargaviGudi
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/origin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 296b96fe-238f-4bcd-aaf9-b2a6acf95eba

📥 Commits

Reviewing files that changed from the base of the PR and between a4d0d53 and 4904749.

📒 Files selected for processing (1)

• ci-operator/config/openshift/origin/openshift-origin-main.yaml

---

Walkthrough

Three --allow-missing-architectures arguments for e2e-quay-io-openshifttest-additional-storage-tests-... image tags are appended to the verify-image-manifest-lists command in the OpenShift origin main CI configuration, permitting those images to skip missing-architecture manifest failures.

Changes

CI Manifest List Allowlist

Layer / File(s)	Summary
Allow missing architectures for storage test images ci-operator/config/openshift/origin/openshift-origin-main.yaml	Three new --allow-missing-architectures entries added to the verify-image-manifest-lists step, whitelisting specific e2e-quay-io-openshifttest-additional-storage-tests-... image tags.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'OCPNODE-4055: Allow missing architectures for Additional Storage test images' clearly summarizes the main change: adding architecture exceptions for Additional Storage test images.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This PR modifies only CI configuration YAML files and does not add or modify any Ginkgo test definitions. The check for stable test names is not applicable.
Test Structure And Quality	✅ Passed	PR modifies only CI configuration (openshift-origin-main.yaml), not Ginkgo test code. Custom check is not applicable to configuration-only changes.
Microshift Test Compatibility	✅ Passed	This PR modifies only CI configuration (verify-image-manifest-lists job) and adds no Ginkgo e2e test code. The check applies only when new tests are added; since no tests are in this PR, the check...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR contains only CI configuration changes (YAML) with no Ginkgo e2e tests being added. The SNO compatibility check applies only to new test code, not CI configuration changes.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies only CI configuration to allow test images to skip architecture manifest verification. It does not introduce deployment manifests, operator code, controllers, or any scheduling con...
Ote Binary Stdout Contract	✅ Passed	PR modifies only a YAML CI/CD configuration file, not Go source code. The OTE Binary Stdout Contract check applies to executable code, not configuration files.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only modifies CI configuration (YAML) and adds no Ginkgo e2e tests; check is not applicable to configuration-only changes.
No-Weak-Crypto	✅ Passed	PR only modifies YAML configuration file adding command-line flags; no cryptographic code, weak crypto, or secret comparisons present.
Container-Privileges	✅ Passed	File is a CI-Operator configuration (not a K8s manifest) with no privileged containers, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds configuration parameters for image identifiers to a CI test, containing no passwords, tokens, API keys, PII, or other sensitive data that would be exposed in logs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@BhargaviGudi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-origin-main-verify-image-manifest-lists	openshift/origin	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.