CompliaceAsCode: Use content image from PR to test rules on 4.22 RHCOS10#80828
Conversation
Let's use a content image built from the PR, rather than the default image: quay.io/redhat-user-workloads/ocp-isc-tenant/compliance-operator-content-dev:master
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughTwo Changesrhcos10 e2e CONTENT_IMAGE wiring
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/pj-rehearse |
|
@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
The change is working correctly: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Anna-Koudelkova, taimurhafeez, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
5e89546
into
openshift:main
|
@yuumasato: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Let's use a content image built from the PR, rather than the default image:
quay.io/redhat-user-workloads/ocp-isc-tenant/compliance-operator-content-dev:master
While reviewing ComplianceAsCode/content#14812 and looking at test:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/ComplianceAsCode_content/14812/pull-ci-ComplianceAsCode-content-master-4.22-e2e-aws-openshift-node-compliance-rhcos10/2068004200914096128
I noticed that it used the default image rather than an image built from the PR with Alex's changes:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/ComplianceAsCode_content/14812/pull-ci-ComplianceAsCode-content-master-4.22-e2e-aws-openshift-node-compliance-rhcos10/2068004200914096128/artifacts/e2e-aws-openshift-node-compliance-rhcos10/test/build-log.txt
Summary by CodeRabbit
This PR updates the OpenShift CI configuration for the ComplianceAsCode/content repository to ensure that the RHEL 10/RHCOS10 compliance testing jobs use the content image built from the pull request under review.
What changed:
The CI configuration for the
e2e-aws-openshift-platform-compliance-rhcos10ande2e-aws-openshift-node-compliance-rhcos10test jobs now explicitly pass the-content-image="$CONTENT_IMAGE"flag to the compliance test commands and declare a dependency on theocp4-content-dsimage component.Why this matters:
Previously, these RHCOS10-specific compliance tests were not using the PR-built content image, meaning they would test against a stale or default image rather than the actual compliance rules and changes submitted in a pull request. This change aligns the RHCOS10 tests with the existing behavior of the standard (non-RHCOS10) compliance tests, ensuring that all compliance changes are properly validated before merge. This provides more accurate testing results for RHEL 10 / RHCOS10 compliance scenarios.