Skip to content

OCPBUGS-88732: CCCMO add trigger-only AWS CCM regression presubmit#80829

Open
RadekManak wants to merge 3 commits into
openshift:mainfrom
RadekManak:cccmo-aws-regression-presubmit
Open

OCPBUGS-88732: CCCMO add trigger-only AWS CCM regression presubmit#80829
RadekManak wants to merge 3 commits into
openshift:mainfrom
RadekManak:cccmo-aws-regression-presubmit

Conversation

@RadekManak

@RadekManak RadekManak commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an AWS regression-clusterinfra-aws-ipi-ccm presubmit for cluster-cloud-controller-manager-operator
  • keep the new AWS job trigger-only instead of file-triggered because the same regression job already exists for vSphere

Summary by CodeRabbit

This PR updates the CI configuration for the cluster-cloud-controller-manager-operator repository to support an AWS-specific CCM regression presubmit that runs on demand.

What's changing: A new optional test entry, regression-clusterinfra-aws-ipi-ccm, is added to the tests list. It targets AWS IPI using the openshift-org-aws cluster profile and runs the openshift-e2e-test-clusterinfra-qe-regression chain via the cucushift-installer-rehearse-aws-ipi workflow, with CCM-focused selection (E2E_RUN_TAGS=@ccm``, TEST_FILTERS_CLUSTERINFRASTRUCTURE=ccm&&!qe-only, `TEST_SCENARIOS=Cluster_Infrastructure CCM`).

Trigger-only behavior: The job is intentionally configured to be trigger-only (not automatically executed on every change) by setting always_run: false in the ci-operator source config, matching the existing vSphere regression pattern and avoiding duplicate cross-cloud regression runs. Developers can invoke the AWS regression explicitly when needed via PR comments.

…egression presubmit

Add the AWS CCM regression presubmit and keep it trigger-only so it runs only when explicitly requested.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RadekManak
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9dafce73-a140-403a-9c9b-6ae8ea7bed83

📥 Commits

Reviewing files that changed from the base of the PR and between 31d3727 and be4e9b9.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-main.yaml

Walkthrough

A new optional test entry regression-clusterinfra-aws-ipi-ccm is added to the CI config for cluster-cloud-controller-manager-operator. It uses the openshift-org-aws cluster profile, sets CCM-specific test filters and scenario variables, and executes via the cucushift-installer-rehearse-aws-ipi workflow.

Changes

AWS IPI CCM Regression Test Job

Layer / File(s) Summary
AWS IPI CCM Regression Test Entry
ci-operator/config/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-main.yaml
Adds an optional test job with openshift-org-aws cluster profile, E2E_RUN_TAGS=@ccm``, TEST_FILTERS_CLUSTERINFRASTRUCTURE=ccm&&!qe-only, `TEST_SCENARIOS=Cluster_Infrastructure CCM`, running the `openshift-e2e-test-clusterinfra-qe-regression` chain via `cucushift-installer-rehearse-aws-ipi`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: adding a trigger-only AWS CCM regression presubmit job to the cluster-cloud-controller-manager-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only CI operator configuration (YAML), not Ginkgo test code. The custom check for stable test names applies to Ginkgo tests, which are not present in this PR.
Test Structure And Quality ✅ Passed This PR modifies CI operator and Prow configuration files (YAML only). The custom check for Ginkgo test code quality is not applicable since there are no test files or test code in this pull request.
Microshift Test Compatibility ✅ Passed PR adds CI job configuration only (no new Ginkgo test code). The custom check applies only when new Ginkgo tests are added; this PR runs existing test workflows via ci-operator configuration.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI configuration (YAML), not Ginkgo e2e test code. No new tests with It(), Describe(), Context(), or When() added.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI/CD configuration files, not deployment manifests, operator code, or controllers. Topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR modifies only CI configuration YAML files, not source code. OTE Binary Stdout Contract check applies to process-level code (main, init, TestMain, suite setup) - none of which are present in this...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds CI configuration for a regression test job, not new Ginkgo e2e test code. Check applies only to new Ginkgo tests, not CI config files.
No-Weak-Crypto ✅ Passed The PR only modifies CI/CD configuration YAML to add an AWS regression test job. No cryptographic code, weak crypto algorithms, or token/secret comparisons are present.
Container-Privileges ✅ Passed Pull request modifies only CI/CD configuration (ci-operator YAML), not container/Kubernetes manifests. No privileged configurations found.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds a CI configuration entry with test orchestration settings only. Environment variables contain test filter tags and scenario names; no passwords, tokens, API keys, or PII are exposed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@RadekManak RadekManak changed the title Cluster cloud controller manager operator: add trigger-only AWS CCM regression presubmit OCPBUGS-88732: CCCMO add trigger-only AWS CCM regression presubmit Jun 22, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@RadekManak: This pull request references Jira Issue OCPBUGS-88732, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • add an AWS regression-clusterinfra-aws-ipi-ccm presubmit for cluster-cloud-controller-manager-operator
  • keep the new AWS job trigger-only instead of file-triggered because the same regression job already exists for vSphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RadekManak and others added 2 commits June 22, 2026 13:10
…esubmit trigger-only

Set always_run to false in the source ci-operator config so generated Prow config matches the intended trigger-only behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>
…r for metadata

Place always_run before as so determinize-ci-operator output matches the source config.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@RadekManak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-cloud-controller-manager-operator-main-regression-clusterinfra-aws-ipi-ccm openshift/cluster-cloud-controller-manager-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RadekManak

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@RadekManak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/main/regression-clusterinfra-aws-ipi-ccm be4e9b9 link unknown /pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-regression-clusterinfra-aws-ipi-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RadekManak

Copy link
Copy Markdown
Contributor Author

Tests failure is expected.
/pj-rehearse ack
/assign @theobarberbany for approval

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 23, 2026
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@RadekManak: GitHub didn't allow me to assign the following users: approval, for.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Tests failure is expected.
/pj-rehearse ack
/assign @theobarberbany for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants