Skip to content

hypershift/openstack: Increase timeout for jobs#80833

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:increase-openstack-hypershift-timeout
Jun 23, 2026
Merged

hypershift/openstack: Increase timeout for jobs#80833
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:increase-openstack-hypershift-timeout

Conversation

@stephenfin

@stephenfin stephenfin commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

These are regularly timing out. Lets increase the timeout temporarily to see if we can get a result out of the CI.

Summary by CodeRabbit

This PR increases execution timeouts for the OpenShift hypershift OpenStack e2e tests across multiple release branches to address recurring timeout failures in the CI pipeline.

Affected CI configurations:

  • Added explicit timeout: 6h0m0s to the e2e-openstack-aws test job in:
    • openshift-hypershift-main.yaml
    • openshift-hypershift-release-4.23.yaml
    • openshift-hypershift-release-5.0.yaml
    • openshift-hypershift-release-5.1.yaml

Test execution changes:

  • Increased the Go test timeout in the hypershift OpenStack e2e execute script from 2h30m to 3h30m to allow longer test execution times

These timeout adjustments are intended to be temporary while the underlying timeout issues are investigated, allowing the CI pipeline to complete successfully and provide meaningful test results for hypershift OpenStack deployments.

These are regularly timing out. Lets increase the timeout temporarily to see
if we can get a result out of the CI.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f99ffa45-21f3-4621-851e-45f13d35c9be

📥 Commits

Reviewing files that changed from the base of the PR and between b6ad29a and c267f8d.

⛔ Files ignored due to path filters (4)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1.yaml
  • ci-operator/step-registry/hypershift/openstack/e2e/execute/hypershift-openstack-e2e-execute-commands.sh

Walkthrough

The e2e-openstack-aws CI job receives an explicit timeout: 6h0m0s in the CI operator configs for the main, release-4.23, release-5.0, and release-5.1 branches. The Go test timeout inside the execute script is also increased from 2h30m to 3h30m.

Changes

OpenStack E2E Timeout Increase

Layer / File(s) Summary
CI job timeout config across branches
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1.yaml
Adds timeout: 6h0m0s to the e2e-openstack-aws job entry in all four branch configs.
Go test execution timeout
ci-operator/step-registry/hypershift/openstack/e2e/execute/hypershift-openstack-e2e-execute-commands.sh
Increases --test.timeout from 2h30m to 3h30m in the E2E execute script.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, approved, rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: increasing timeout for hypershift/openstack jobs, which matches the changeset's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files and shell script timeout parameters. No Ginkgo test definitions (It(), Describe(), etc.) are changed, so the test name stability check is not applicable.
Test Structure And Quality ✅ Passed This PR modifies only CI/CD configuration files (YAML config and shell scripts), not Ginkgo test code. The check requires reviewing "Ginkgo test code for quality requirements," but the repository i...
Microshift Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only adjusts CI timeouts in YAML config and shell scripts. The MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only adjusts timeout configurations for existing CI jobs. The custom check for SNO compatibility is only applicable when new e2e tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed Changes are CI job timeout configurations, not deployment manifests or operator code; no scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI timeout configurations in YAML and shell script arguments; no changes to process-level code or stdout behavior in any OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only adjusts timeout settings on existing tests; no new Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check does not apply.
No-Weak-Crypto ✅ Passed PR contains no cryptographic code. Changes are solely timeout configuration adjustments to CI test jobs and shell scripts.
Container-Privileges ✅ Passed PR contains only timeout configuration changes in CI/CD files and shell scripts. No Kubernetes manifests or container privilege settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allow...
No-Sensitive-Data-In-Logs ✅ Passed PR only adds timeout configuration values (6h0m0s and 3h30m). No new logging code or sensitive data exposure patterns were introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from devguyio and gryf June 22, 2026 11:08
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stephenfin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-main-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-5.1-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-5.0-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.23-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.22-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.21-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.20-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.19-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.18-e2e-openstack-hypershift openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-main-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-release-5.1-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-release-5.0-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-release-4.23-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-release-4.22-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-release-4.21-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-release-4.20-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-openstack-resource-controller-release-4.19-e2e-hypershift openshift/openstack-resource-controller presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-openstack-release-5.1-e2e-hypershift openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-openstack-release-5.0-e2e-hypershift openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.23-e2e-hypershift openshift/cluster-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.0-e2e-openstack-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-openstack-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-5.1-e2e-openstack-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.23-e2e-openstack-aws openshift/hypershift presubmit Ci-operator config changed

A total of 32 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mandre mandre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2026
@csrwng

csrwng commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@stephenfin

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

Nothing to rehearse here: the job is currently broken (we're working on it in openshift/hypershift#8687)

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 23, 2026
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit d865dc5 into openshift:main Jun 23, 2026
18 checks passed
@openshift-merge-bot openshift-merge-bot Bot deleted the increase-openstack-hypershift-timeout branch June 23, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants