Skip to content

fix: update eval-address-reviews config path for openshift-eng/ai-helpers#80842

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:fix-eval-address-reviews-config
Jun 22, 2026
Merged

fix: update eval-address-reviews config path for openshift-eng/ai-helpers#80842
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:fix-eval-address-reviews-config

Conversation

@bryan-cox

@bryan-cox bryan-cox commented Jun 22, 2026

Copy link
Copy Markdown
Member

The eval config for address-reviews was renamed from address-reviews.yaml to eval-address-reviews.yaml in openshift-eng/ai-helpers#558 to follow the eval harness naming convention (eval-*.yaml prefix). This updates the CI config to match.

Failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift-eng_ai-helpers/558/pull-ci-openshift-eng-ai-helpers-main-eval-address-reviews/2069061381935599616

Summary by CodeRabbit

This PR updates the OpenShift CI configuration for the ai-helpers repository to reference an eval configuration file that was recently renamed. The eval-address-reviews test step in the CI operator configuration now points to plugins/utils/evals/eval-address-reviews.yaml instead of plugins/utils/evals/address-reviews.yaml. This change aligns the reference with a file rename that was made in the upstream ai-helpers repository to follow the eval harness naming convention, which requires eval configuration files to use an eval-*.yaml prefix.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2cbf960f-746b-45e8-8fc4-664dc251e49c

📥 Commits

Reviewing files that changed from the base of the PR and between c985bbf and e2fa611.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml

Walkthrough

In the openshift-eng-ai-helpers-main.yaml CI config, the EVAL_CONFIG environment variable for the eval-address-reviews test step is updated to reference plugins/utils/evals/eval-address-reviews.yaml instead of plugins/utils/evals/address-reviews.yaml.

Changes

CI Config Path Fix

Layer / File(s) Summary
EVAL_CONFIG path correction
ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml
EVAL_CONFIG in the eval-address-reviews test step is changed from plugins/utils/evals/address-reviews.yaml to plugins/utils/evals/eval-address-reviews.yaml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the eval-address-reviews config path in the CI configuration for openshift-eng/ai-helpers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only CI configuration files (YAML), not Ginkgo test code. The repository contains no Ginkgo test definitions. The check for stable test names is not applicable to this change.
Test Structure And Quality ✅ Passed This PR modifies CI configuration and documentation files only; it contains no Ginkgo test code. The custom check for test structure/quality is not applicable.
Microshift Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests; it only updates a CI config file path reference for an eval configuration file rename.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only updates a CI configuration file path reference and does not add any new Ginkgo e2e tests, making the SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only updates a CI configuration file path reference (env.EVAL_CONFIG) and does not involve deployment manifests, operator code, or controllers that would introduce scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML files, not binary/process-level code that could write to stdout, so the OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests; it only updates a CI configuration file path reference, so the IPv6/disconnected network compatibility check is not applicable.
No-Weak-Crypto ✅ Passed PR updates only CI configuration path for eval config file; no cryptographic implementations, MD5/SHA1/DES/RC4/3DES/Blowfish/ECB usage, or weak secret comparisons detected.
Container-Privileges ✅ Passed This CI configuration file contains no container/K8s manifest declarations with privileged settings, hostPID, hostNetwork, hostIPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation flags. The PR...
No-Sensitive-Data-In-Logs ✅ Passed PR only updates a config file path reference with no logging code or sensitive data exposure. The change updates EVAL_CONFIG from address-reviews.yaml to eval-address-reviews.yaml in a CI configura...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from ashishmax31 and bennerv June 22, 2026 14:27
@bryan-cox bryan-cox force-pushed the fix-eval-address-reviews-config branch from 4025b22 to f86723b Compare June 22, 2026 14:27
The eval config was renamed from address-reviews.yaml to
eval-address-reviews.yaml to follow the eval harness naming
convention (eval-*.yaml prefix).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bryan-cox bryan-cox force-pushed the fix-eval-address-reviews-config branch from f86723b to e2fa611 Compare June 22, 2026 14:27
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@bryan-cox

Copy link
Copy Markdown
Member Author

/pj-rehearse skip

I'll test this in a follow up PR

@stbenjam

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2026
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bryan-cox: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@bryan-cox

Copy link
Copy Markdown
Member Author

/pj-rehearse skip

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bryan-cox: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ai-helpers-main-eval-address-reviews openshift-eng/ai-helpers presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bryan-cox

Copy link
Copy Markdown
Member Author

/pj-rehearse skip

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 22, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 2f1eb6b into openshift:main Jun 22, 2026
14 checks passed
@bryan-cox bryan-cox deleted the fix-eval-address-reviews-config branch June 22, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants