fix: update eval-address-reviews config path for openshift-eng/ai-helpers#80842
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughIn the ChangesCI Config Path Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4025b22 to
f86723b
Compare
The eval config was renamed from address-reviews.yaml to eval-address-reviews.yaml to follow the eval harness naming convention (eval-*.yaml prefix). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f86723b to
e2fa611
Compare
|
/pj-rehearse skip I'll test this in a follow up PR |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bryan-cox: |
|
/pj-rehearse skip |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse skip |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The eval config for address-reviews was renamed from
address-reviews.yamltoeval-address-reviews.yamlin openshift-eng/ai-helpers#558 to follow the eval harness naming convention (eval-*.yamlprefix). This updates the CI config to match.Failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift-eng_ai-helpers/558/pull-ci-openshift-eng-ai-helpers-main-eval-address-reviews/2069061381935599616
Summary by CodeRabbit
This PR updates the OpenShift CI configuration for the ai-helpers repository to reference an eval configuration file that was recently renamed. The
eval-address-reviewstest step in the CI operator configuration now points toplugins/utils/evals/eval-address-reviews.yamlinstead ofplugins/utils/evals/address-reviews.yaml. This change aligns the reference with a file rename that was made in the upstream ai-helpers repository to follow the eval harness naming convention, which requires eval configuration files to use aneval-*.yamlprefix.