Skip to content

ci: add e2e-sbr-weekly-aws-efs periodic for medik8s/system-tests#80995

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
maximunited:worktree-sbr-efs-periodic
Jun 29, 2026
Merged

ci: add e2e-sbr-weekly-aws-efs periodic for medik8s/system-tests#80995
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
maximunited:worktree-sbr-efs-periodic

Conversation

@maximunited

@maximunited maximunited commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What

Adds e2e-sbr-weekly-aws-efs periodic job for medik8s/system-tests, running every Sunday at 10:00 UTC — a weekly EFS counterpart to the existing e2e-sbr-weekly-aws-odf job.

Why

e2e-sbr-weekly-aws-odf already covers ODF/CephFS as a RWX backend for SBR. EFS (NFS-based) exercises a different kernel path, different failure mode, and different I/O error propagation on storage loss. A dedicated periodic ensures continuous coverage of both backends.

How

Mirrors e2e-sbr-weekly-aws-odf with the following changes:

ODF weekly EFS weekly
Storage setup odf-prepare-cluster, operatorhub-subscribe-odf-operator, odf-apply-storage-cluster storage-create-csi-aws-efs-sts-operator-role, storage-subscribe-aws-efs-csi-driver, storage-create-csi-aws-efs, storage-conf-wait-for-csi-driver
Post medik8s-polarion-reporter (workflow handles teardown) medik8s-polarion-reporterstorage-destroy-csi-aws-efs-sts-operator-roleipi-aws-post (EFS STS role must be destroyed before cluster teardown)
Extra env COMPUTE_NODE_TYPE: m5.4xlarge, ODF_OPERATOR_SUB_CHANNEL: stable-4.21 CLUSTERCSIDRIVER: efs.csi.aws.com, TEST_CSI_DRIVER_MANIFEST: manifest-aws-efs.yaml, TRUECONDITIONS: AWSEFSDriverControllerServiceControllerAvailable AWSEFSDriverNodeServiceControllerAvailable
Cron 0 6 * * 0 (Sun 06:00 UTC) 0 10 * * 0 (Sun 10:00 UTC)
Polarion run RHWA-SBR-4.22-weekly RHWA-SBR-4.22-weekly-efs

Presubmit reference

The EFS setup steps and env vars are copied directly from the e2e-sbr-aws-efs presubmit merged in #80362.

Summary by CodeRabbit

This change updates the medik8s/system-tests CI configuration by adding a new weekly AWS EFS end-to-end job, e2e-sbr-weekly-aws-efs. Practically, it introduces an EFS-based counterpart to the existing weekly AWS ODF job, scheduled to run every Sunday at 10:00 UTC (cron 0 10 * * 0).

The new job targets the medik8s-aws cluster profile and swaps the storage setup/teardown flow from ODF/CephFS to AWS EFS. It provisions AWS EFS CSI prerequisites via:

  • storage-create-csi-aws-efs-sts-operator-role
  • storage-subscribe-aws-efs-csi-driver
  • storage-create-csi-aws-efs
  • storage-conf-wait-for-csi-driver

In the post phase, it reports results through medik8s-polarion-reporter, then explicitly destroys the EFS STS operator role with storage-destroy-csi-aws-efs-sts-operator-role before running ipi-aws-post, ensuring the EFS STS role is cleaned up prior to cluster teardown.

The job also sets EFS CSI–specific environment variables, including:

  • CLUSTERCSIDRIVER=efs.csi.aws.com
  • TEST_CSI_DRIVER_MANIFEST=manifest-aws-efs.yaml
  • TRUECONDITIONS=AWSEFSDriverControllerServiceControllerAvailable AWSEFSDriverNodeServiceControllerAvailable

Additionally, it configures test execution/reporting by setting the Polarion run ID to RHWA-SBR-4.22-weekly-efs (POLARION_TESTRUN_ID) and uses SBR-related variables such as REPORT_CASE_TAG, ECO_TC_PREFIX, ECO_TEST_FEATURES, and OCP_VERSION: "422" for the make run-tests step.

The new periodic job configuration was rehearsed via the standard Konflux periodic-ci rehearsal command.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

A new weekly scheduled E2E job, e2e-sbr-weekly-aws-efs, is added to the medik8s system-tests CI config for OCP 4.22. It uses the medik8s-aws cluster profile, wires AWS EFS CSI settings, runs Polarion reporting, provisions and tears down EFS resources, and executes make run-tests.

Changes

Weekly AWS EFS E2E Job

Layer / File(s) Summary
Job definition and post steps
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
Adds the weekly e2e-sbr-weekly-aws-efs job with medik8s-aws, SBR and EFS CSI environment wiring, and the post phase for Polarion reporting plus AWS EFS CSI cleanup.
Test phase steps
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml
Defines the test phase that subscribes the catalog, provisions AWS EFS CSI resources, waits for the driver, and runs make run-tests with test environment variables and resource requests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/release#80362: Adds the same e2e-sbr-aws-efs job pattern in the same file, including the EFS CSI setup and SBR wiring.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • razo7
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding the e2e-sbr-weekly-aws-efs periodic job for medik8s/system-tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only adds a ci-operator job stanza; no It/Describe/Context/When titles or dynamic test names appear in the changed file.
Test Structure And Quality ✅ Passed Only a CI job YAML was changed; no Ginkgo test code was added or modified, so the test-structure checklist is not applicable.
Microshift Test Compatibility ✅ Passed The PR only changes ci-operator YAML for a periodic job; no new Ginkgo tests, Go files, or MicroShift-sensitive test code were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: PR only adds a periodic CI job YAML; no Ginkgo tests or topology-sensitive code were added, so there’s no new SNO compatibility risk to assess.
Topology-Aware Scheduling Compatibility ✅ Passed The change only adds a CI periodic job config and storage test refs; it introduces no pod scheduling rules, node selectors, anti-affinity, or topology-dependent controllers.
Ote Binary Stdout Contract ✅ Passed PASS: The PR only adds/updates CI job YAML; no process-level code or stdout writes were introduced in main/init/TestMain/suite setup.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: This PR only adds/updates a CI job config; it adds no Ginkgo tests and no IPv4 literals or public hostnames were introduced.
No-Weak-Crypto ✅ Passed PASS — the added YAML only defines CI job refs/env vars; no weak crypto primitives, custom crypto, or secret/token comparisons appear in the change.
Container-Privileges ✅ Passed The new EFS job and its referenced EFS step files contain no privileged/host* fields, allowPrivilegeEscalation, SYS_ADMIN, or root securityContext.
No-Sensitive-Data-In-Logs ✅ Passed The change only adds CI job config; it doesn't introduce logs printing passwords, tokens, API keys, PII, or other sensitive data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026
@openshift-ci openshift-ci Bot requested review from mshitrit and razo7 June 24, 2026 13:03
@maximunited

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-efs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@maximunited: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2026
Mirrors e2e-sbr-weekly-aws-odf with EFS-specific setup steps,
runs every Sunday at 12:00 UTC (slot between MDR at 10:00 and NHC at 14:00).

Changes from ODF weekly:
- EFS setup steps (storage-create-csi-aws-efs-sts-operator-role,
  storage-subscribe-aws-efs-csi-driver, storage-create-csi-aws-efs,
  storage-conf-wait-for-csi-driver) replace ODF operator setup
- Explicit post: medik8s-polarion-reporter → storage-destroy-csi-aws-efs-sts-operator-role
  → ipi-aws-post (EFS STS role must be destroyed before cluster teardown)
- CLUSTERCSIDRIVER, TEST_CSI_DRIVER_MANIFEST, TRUECONDITIONS env vars added
- COMPUTE_NODE_TYPE and ODF_OPERATOR_SUB_CHANNEL removed (not needed for EFS)
- POLARION_TESTRUN_ID: RHWA-SBR-4.22-weekly-efs
@maximunited maximunited force-pushed the worktree-sbr-efs-periodic branch from 42d8979 to bae4628 Compare June 24, 2026 15:06
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2026
@maximunited

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-efs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@maximunited: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

maximunited and others added 2 commits June 25, 2026 10:01
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maximunited: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-efs N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@maximunited

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-sbr-weekly-aws-efs

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@maximunited: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2026
@openshift-ci

openshift-ci Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximunited, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maximunited

Copy link
Copy Markdown
Contributor Author

/rehearsals-ack

@maximunited

Copy link
Copy Markdown
Contributor Author

/label rehearsals-ack

@maximunited

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@maximunited: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maximunited

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@maximunited: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 29, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit ef6669c into openshift:main Jun 29, 2026
16 of 17 checks passed
krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
…nshift#80995)

* ci: add e2e-sbr-weekly-aws-efs periodic for medik8s/system-tests

Mirrors e2e-sbr-weekly-aws-odf with EFS-specific setup steps,
runs every Sunday at 12:00 UTC (slot between MDR at 10:00 and NHC at 14:00).

Changes from ODF weekly:
- EFS setup steps (storage-create-csi-aws-efs-sts-operator-role,
  storage-subscribe-aws-efs-csi-driver, storage-create-csi-aws-efs,
  storage-conf-wait-for-csi-driver) replace ODF operator setup
- Explicit post: medik8s-polarion-reporter → storage-destroy-csi-aws-efs-sts-operator-role
  → ipi-aws-post (EFS STS role must be destroyed before cluster teardown)
- CLUSTERCSIDRIVER, TEST_CSI_DRIVER_MANIFEST, TRUECONDITIONS env vars added
- COMPUTE_NODE_TYPE and ODF_OPERATOR_SUB_CHANNEL removed (not needed for EFS)
- POLARION_TESTRUN_ID: RHWA-SBR-4.22-weekly-efs

* ci: update e2e-sbr-weekly-aws-efs cron to Sunday 10:00 UTC

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: regenerate jobs for e2e-sbr-weekly-aws-efs cron update

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
…nshift#80995)

* ci: add e2e-sbr-weekly-aws-efs periodic for medik8s/system-tests

Mirrors e2e-sbr-weekly-aws-odf with EFS-specific setup steps,
runs every Sunday at 12:00 UTC (slot between MDR at 10:00 and NHC at 14:00).

Changes from ODF weekly:
- EFS setup steps (storage-create-csi-aws-efs-sts-operator-role,
  storage-subscribe-aws-efs-csi-driver, storage-create-csi-aws-efs,
  storage-conf-wait-for-csi-driver) replace ODF operator setup
- Explicit post: medik8s-polarion-reporter → storage-destroy-csi-aws-efs-sts-operator-role
  → ipi-aws-post (EFS STS role must be destroyed before cluster teardown)
- CLUSTERCSIDRIVER, TEST_CSI_DRIVER_MANIFEST, TRUECONDITIONS env vars added
- COMPUTE_NODE_TYPE and ODF_OPERATOR_SUB_CHANNEL removed (not needed for EFS)
- POLARION_TESTRUN_ID: RHWA-SBR-4.22-weekly-efs

* ci: update e2e-sbr-weekly-aws-efs cron to Sunday 10:00 UTC

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: regenerate jobs for e2e-sbr-weekly-aws-efs cron update

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jul 8, 2026
…nshift#80995)

* ci: add e2e-sbr-weekly-aws-efs periodic for medik8s/system-tests

Mirrors e2e-sbr-weekly-aws-odf with EFS-specific setup steps,
runs every Sunday at 12:00 UTC (slot between MDR at 10:00 and NHC at 14:00).

Changes from ODF weekly:
- EFS setup steps (storage-create-csi-aws-efs-sts-operator-role,
  storage-subscribe-aws-efs-csi-driver, storage-create-csi-aws-efs,
  storage-conf-wait-for-csi-driver) replace ODF operator setup
- Explicit post: medik8s-polarion-reporter → storage-destroy-csi-aws-efs-sts-operator-role
  → ipi-aws-post (EFS STS role must be destroyed before cluster teardown)
- CLUSTERCSIDRIVER, TEST_CSI_DRIVER_MANIFEST, TRUECONDITIONS env vars added
- COMPUTE_NODE_TYPE and ODF_OPERATOR_SUB_CHANNEL removed (not needed for EFS)
- POLARION_TESTRUN_ID: RHWA-SBR-4.22-weekly-efs

* ci: update e2e-sbr-weekly-aws-efs cron to Sunday 10:00 UTC

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: regenerate jobs for e2e-sbr-weekly-aws-efs cron update

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants