Skip to content

Support flexible machine config for PowerVS #83161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonia-garudi wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −3
Open

Support flexible machine config for PowerVS #83161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...ate/ibmcloud-workers/infra/hypershift-mce-power-create-ibmcloud-workers-infra-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,15 @@ update_agentserviceconfig() {
set_power_configs() {
# PowerVS VSI(Virtual Server Instance) configs
POWERVS_VSI_NAME="power-${HOSTED_CLUSTER_NAME}-worker"
POWERVS_VSI_MEMORY=$(jq -r '.powervsVSIMemory' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json")
POWERVS_VSI_PROCESSORS=$(jq -r '.powervsVSIProcessors' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json")
POWERVS_VSI_PROC_TYPE=$(jq -r '.powervsVSIProcType' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json")
if [[ -z "${POWERVS_VSI_MEMORY}" ]]; then
POWERVS_VSI_MEMORY=$(jq -r '.powervsVSIMemory' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json")
fi
if [[ -z "${POWERVS_VSI_PROCESSORS}" ]]; then
POWERVS_VSI_PROCESSORS=$(jq -r '.powervsVSIProcessors' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json")
fi
if [[ -z "${POWERVS_VSI_PROC_TYPE}" ]]; then
POWERVS_VSI_PROC_TYPE=$(jq -r '.powervsVSIProcType' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json")
fi
Comment on lines +106 to +114

@prb112 prb112 Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should just set the bash defaults ...

POWERVS_VSI_MEMORY=${POWERVS_VSI_MEMORY:-$(jq -r '.powervsVSIMemory' "$json_file")}
POWERVS_VSI_PROCESSORS=${POWERVS_VSI_PROCESSORS:-$(jq -r '.powervsVSIProcessors' "$json_file")}
POWERVS_VSI_PROC_TYPE=${POWERVS_VSI_PROC_TYPE:-$(jq -r '.powervsVSIProcType' "$json_file")}

if [ ${IS_HETEROGENEOUS} == "yes" ]; then
# NOTE: Using e980 as a workaround for VPC Load Balancer connectivity issues with
# s922 in heterogeneous node pools, until a permanent fix.
Expand Down
9 changes: 9 additions & 0 deletions ...create/ibmcloud-workers/infra/hypershift-mce-power-create-ibmcloud-workers-infra-ref.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ ref:
- name: IS_HETEROGENEOUS
documentation: "Flag to indicate whether the power workers being created are part of a heterogeneous cluster"
default: "no"
- name: POWERVS_VSI_MEMORY
documentation: "Memory in GB for PowerVS worker VSI. If empty, reads from ibmcloud-resources.json"
default: ""
- name: POWERVS_VSI_PROCESSORS
documentation: "Number of processors for PowerVS worker VSI. If empty, reads from ibmcloud-resources.json"
default: ""
- name: POWERVS_VSI_PROC_TYPE
documentation: "Processor type for PowerVS worker VSI (shared/dedicated/capped). If empty, reads from ibmcloud-resources.json"
default: ""
commands: hypershift-mce-power-create-ibmcloud-workers-infra-commands.sh
from: dev-scripts
grace_period: 15m0s
Expand Down