[update] Retag customContainerImages in OpenStackVersion CR during minor update#3764
Draft
rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Draft
[update] Retag customContainerImages in OpenStackVersion CR during minor update#3764rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
customContainerImages in OpenStackVersion CR during minor update#3764rebtoor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…g minor update Starting with openstack-operator FR4 (openstack-k8s-operators/openstack-operator#1569, merged Oct 2025), the `OpenStackVersion` admission webhook rejects `targetVersion` changes when `spec.customContainerImages` are identical to those tracked for the previously deployed version. During the update flow, `set_openstack_containers` updates the operator CSV env vars with the new delorean tag, but nothing updates the `OpenStackVersion` CR's `customContainerImages` -- they still carry the tag from the initial greenfield deployment. When `update_services` later patches `targetVersion`, the webhook rejects the request because the custom images haven't changed. Add a step after `set_openstack_containers` that reads the current `customContainerImages` from the `OpenStackVersion` CR, replaces every image tag with the new delorean md5 hash, and patches the CR. This ensures the custom images reflect the new version before `targetVersion` is changed, satisfying the webhook and guaranteeing the update uses the correct container images. Assisted-by: Cursor (claude-4.6-opus-high) Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with openstack-operator FR4
(openstack-k8s-operators/openstack-operator#1569, merged Oct 2025), the
OpenStackVersionadmission webhook rejectstargetVersionchanges whenspec.customContainerImagesare identical to those tracked for the previously deployed version.During the update flow,
set_openstack_containersupdates the operator CSV env vars with the new delorean tag, but nothing updates theOpenStackVersionCR'scustomContainerImages, they still carry the tag from the initial greenfield deployment. Whenupdate_serviceslater patchestargetVersion, the webhook rejects the request because the custom images haven't changed.Add a step after
set_openstack_containersthat reads the currentcustomContainerImagesfrom theOpenStackVersionCR, replaces every image tag with the new delorean md5 hash, and patches the CR. This ensures the custom images reflect the new version beforetargetVersionis changed, satisfying the webhook and guaranteeing the update uses the correct container images.Assisted-by: Cursor (claude-4.6-opus-high)
Signed-off-by: Roberto Alfieri ralfieri@redhat.com