Update 'losetup' parsing and fix ZFS mount options#1052
Merged
Conversation
bin/mount -t zfs -o rw relatime xattr posixacl tank
instead of
bin/mount -t zfs -o rw,relatime,xattr,posixacl tank
…parsing logic - Switched `losetup` command options to `-O NAME,BACK-FILE` for compatibility with older RHEL versions. - Removed `json.Unmarshal` usage in favor of parsing command output manually. - Simplified `InfoEntry` fields and associated logic for clarity and correctness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
losetupcommand to replace-Jwith-O NAME,BACK-FILEfor improved compatibility with older RHEL versions.json.Unmarshaland implementing a manual parsing approach.InfoEntrystructure and changed field types toanyto handle mixed value formats.mountLegacyoptions for ZFS mounts, correcting option syntax to properly separate values.