fix: catch all exceptions during Zigbee device enrichment#751
Merged
CFenner merged 2 commits intoopenviess:masterfrom Apr 28, 2026
Merged
fix: catch all exceptions during Zigbee device enrichment#751CFenner merged 2 commits intoopenviess:masterfrom
CFenner merged 2 commits intoopenviess:masterfrom
Conversation
GATEWAY_OFFLINE (PyViCareDeviceCommunicationError) was not caught, crashing client initialization when a RoomControl device is offline. Enrichment is best-effort and should never prevent startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__enrichZigbeeDevices()from specific exceptions toExceptionPyViCareDeviceCommunicationError: GATEWAY_OFFLINE)Motivation
#743 added Zigbee device enrichment from RoomControl. The enrichment runs during
__loadInstallations(), so any unhandled exception crashes the entire client initialization. The originalexceptonly caughtKeyError,IndexError, andPyViCareNotSupportedFeatureError, but offline devices throwPyViCareDeviceCommunicationError.Since enrichment is best-effort (errors are logged with traceback, the device is skipped, and initialization continues), catching
Exceptionis appropriate here.Test plan