Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.134.0/containers/python-3/.devcontainer/base.Dockerfile
ARG VARIANT="3.12"
ARG VARIANT="3.13"
FROM mcr.microsoft.com/devcontainers/python:${VARIANT}

ARG POETRY_VERSION="2.1.1"
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dockerfile": "Dockerfile",
"context": "..",
"args": {
"VARIANT": "3.12-bookworm",
"VARIANT": "3.13-bookworm",
"POETRY_VERSION": "2.1.1"
}
},
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: "3.12"
python-version: "3.13"
- name: Ruff Format Check
uses: chartboost/ruff-action@e18ae971ccee1b2d7bbef113930f00c670b78da4 # v1.0.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
os: ["ubuntu-latest"]
python-version: ["3.12"]
python-version: ["3.13"]

steps:
- name: Checkout
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Tests
uses: ./.github/actions/run-unit-tests
with:
python-version: "3.12"
python-version: "3.13"
os: "ubuntu-latest"
is_pr: "true"

Expand All @@ -48,5 +48,5 @@ jobs:
- name: PostgreSQL Integration Tests
uses: ./.github/actions/run-postgres-tests
with:
python-version: "3.12"
python-version: "3.13"
os: "ubuntu-latest"
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.12"]
python-version: ["3.13"]
arch: ["amd64", "arm64"]
include:
- arch: amd64
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.12"]
python-version: ["3.13"]
image-type: ["standard", "bbs"]
include:
- image-type: standard
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scenario-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
if: steps.check-if-scenarios-or-src-changed.outputs.run_tests != 'false'
with:
python-version: "3.12"
python-version: "3.13"
cache: "poetry"
- name: Run Scenario Tests
if: steps.check-if-scenarios-or-src-changed.outputs.run_tests != 'false'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonar-merge-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Tests
uses: ./.github/actions/run-unit-tests
with:
python-version: "3.12"
python-version: "3.13"
os: "ubuntu-latest"
is_pr: "false"
- name: SonarCloud Scan
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
build:
os: "ubuntu-24.04"
tools:
python: "3.12"
python: "3.13"

sphinx:
builder: dirhtml
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ACA-Py -- A Cloud Agent - Python <!-- omit in toc -->

![Python](https://img.shields.io/badge/python-3.12-blue.svg)
![Python](https://img.shields.io/badge/python-3.13-blue.svg)
[![PyPI version](https://img.shields.io/pypi/v/acapy-agent)](https://pypi.org/project/acapy-agent/)
[![Lines of Code](https://sonarcloud.io/api/project_badges/measure?project=openwallet-foundation_acapy&metric=ncloc)](https://sonarcloud.io/summary/new_code?id=openwallet-foundation_acapy)
[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=openwallet-foundation_acapy&metric=coverage)](https://sonarcloud.io/summary/new_code?id=openwallet-foundation_acapy)
Expand Down
4 changes: 2 additions & 2 deletions acapy_agent/anoncreds/issuer.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@
},
)
# entry.name was stored as the schema's ID
return [entry.name for entry in schemas]
return [entry.name for entry in list(schemas)]

Check warning on line 269 in acapy_agent/anoncreds/issuer.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unnecessary `list()` call on an already iterable object.

See more on https://sonarcloud.io/project/issues?id=openwallet-foundation_acapy&issues=AZqjrIeo4iBhJf7yA_TY&open=AZqjrIeo4iBhJf7yA_TY&pullRequest=3911

async def credential_definition_in_wallet(
self, credential_definition_id: str
Expand Down Expand Up @@ -510,7 +510,7 @@
},
)
# entry.name is cred def id when state == finished
return [entry.name for entry in credential_definition_entries]
return [entry.name for entry in list(credential_definition_entries)]

Check warning on line 513 in acapy_agent/anoncreds/issuer.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unnecessary `list()` call on an already iterable object.

See more on https://sonarcloud.io/project/issues?id=openwallet-foundation_acapy&issues=AZqjrIeo4iBhJf7yA_TZ&open=AZqjrIeo4iBhJf7yA_TZ&pullRequest=3911

async def match_created_credential_definitions(
self,
Expand Down
4 changes: 2 additions & 2 deletions acapy_agent/anoncreds/revocation/revocation.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@
},
)
# entry.name was stored as the credential_definition's ID
return [entry.name for entry in rev_reg_defs]
return [entry.name for entry in list(rev_reg_defs)]

Check warning on line 305 in acapy_agent/anoncreds/revocation/revocation.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unnecessary `list()` call on an already iterable object.

See more on https://sonarcloud.io/project/issues?id=openwallet-foundation_acapy&issues=AZqjrIbl4iBhJf7yA_TW&open=AZqjrIbl4iBhJf7yA_TW&pullRequest=3911

async def get_created_revocation_registry_definition_state(
self,
Expand Down Expand Up @@ -686,7 +686,7 @@
raise AnonCredsRevocationError("Error retrieving revocation list") from err

if rev_list_entries:
return [entry.name for entry in rev_list_entries]
return [entry.name for entry in list(rev_list_entries)]

Check warning on line 689 in acapy_agent/anoncreds/revocation/revocation.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unnecessary `list()` call on an already iterable object.

See more on https://sonarcloud.io/project/issues?id=openwallet-foundation_acapy&issues=AZqjrIbl4iBhJf7yA_TX&open=AZqjrIbl4iBhJf7yA_TX&pullRequest=3911

return []

Expand Down
2 changes: 1 addition & 1 deletion demo/playground/examples/Dockerfile.test.runner
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.12-slim
FROM python:3.13-slim
WORKDIR /usr/src/app

# install poetry
Expand Down
1 change: 0 additions & 1 deletion demo/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
asyncpg~=0.30.0
prompt_toolkit~=3.0.51
web.py~=0.62
pygments~=2.19
qrcode[pil]~=8.2
4 changes: 2 additions & 2 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG python_version=3.12
ARG python_version=3.13
FROM python:${python_version}-slim-bookworm AS build

# Install Poetry
Expand All @@ -19,7 +19,7 @@ WORKDIR /src

COPY ./pyproject.toml ./poetry.lock ./
# need to install pysqlcipher3 first to ensure build dependencies are available
RUN pip install --no-cache-dir pysqlcipher3==1.2.0 && \
RUN pip install --no-cache-dir sqlcipher3-wheels==0.5.5 && \
poetry install --no-root

COPY ./acapy_agent ./acapy_agent
Expand Down
16 changes: 13 additions & 3 deletions docker/Dockerfile.demo
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
ARG from_image=ghcr.io/openwallet-foundation/acapy-agent:py3.12-1.3.2
FROM ${from_image}
ARG python_version=3.13
FROM python:${python_version}-slim-bookworm AS build

RUN apt-get update -y && \
apt-get install -y --no-install-recommends \
libsodium23 git curl \
build-essential \
libsqlcipher-dev && \

Check warning on line 8 in docker/Dockerfile.demo

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Sort these package names alphanumerically.

See more on https://sonarcloud.io/project/issues?id=openwallet-foundation_acapy&issues=AZqjrIfb4iBhJf7yA_Tc&open=AZqjrIfb4iBhJf7yA_Tc&pullRequest=3911
apt-get install -y libpq-dev postgresql-client && \
apt-get clean && \
rm -rf /var/lib/apt/lists/*

ENV ENABLE_PTVSD 0
ENV ENABLE_PYDEVD_PYCHARM 0
Expand All @@ -25,11 +34,12 @@

RUN pip3 install --no-cache-dir -e .

RUN mkdir demo && chown -R aries:aries demo && chmod -R ug+rw demo
RUN mkdir demo && chmod -R ug+rw demo

# Copy and install demo code
COPY demo/requirements.txt ./demo/requirements.txt
RUN pip3 install --no-cache-dir -r demo/requirements.txt

Check warning on line 41 in docker/Dockerfile.demo

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Merge this RUN instruction with the consecutive ones.

See more on https://sonarcloud.io/project/issues?id=openwallet-foundation_acapy&issues=AZqjrIfb4iBhJf7yA_Ta&open=AZqjrIfb4iBhJf7yA_Ta&pullRequest=3911
RUN pip3 install git+https://github.com/webpy/webpy.git

COPY demo ./demo

Expand Down
3 changes: 1 addition & 2 deletions docker/Dockerfile.run
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ARG python_version=3.12.4
FROM python:3.12-slim-bookworm
FROM python:3.13-slim-bookworm

RUN apt-get update -y && \
apt-get install -y --no-install-recommends \
Expand Down
3 changes: 1 addition & 2 deletions docker/Dockerfile.test
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ARG python_version=3.12.4
FROM python:${python_version}-slim-bookworm
FROM python:3.13-slim-bookworm

RUN apt-get update -y && \
apt-get install -y --no-install-recommends \
Expand Down
2 changes: 1 addition & 1 deletion docs/deploying/ContainerImagesAndGithubActions.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ above variants it is. Other tags may also be generated for use by developers.

Click [here](https://github.com/openwallet-foundation/acapy/pkgs/container/acapy-agent/versions?filters%5Bversion_type%5D=tagged) to see a current list of the tagged images available for ACA-Py in.

The following is the ACA-Py comntainer images tagging format. In each of the following, `pyV.vv` is the base Python image being used (e.g. `py3.12`):
The following is the ACA-Py comntainer images tagging format. In each of the following, `pyV.vv` is the base Python image being used (e.g. `py3.13`):

- Regular Releases: `pyV.vv-X.Y.Z` where `X.Y.Z` is the ACA-Py release. The `Z` component may have an `rcN` appended when the tag is for a Release Candidate.
- Nightlies: `pyV-vv-nightly-YYYY-MM-DD` and `pyV-vv-nightly`
Expand Down
2 changes: 1 addition & 1 deletion docs/features/devcontainer.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ To open ACA-Py in a devcontainer, we open the *root* of this repository. We can

#### devcontainer.json

When the [.devcontainer/devcontainer.json](https://github.com/openwallet-foundation/acapy/blob/main/.devcontainer/devcontainer.json) is opened, you will see it building... it is building a Python 3.12 image (bash shell) and loading it with all the ACA-Py requirements. We also load a few Visual Studio settings (for running Pytests and formatting with Ruff).
When the [.devcontainer/devcontainer.json](https://github.com/openwallet-foundation/acapy/blob/main/.devcontainer/devcontainer.json) is opened, you will see it building... it is building a Python 3.13 image (bash shell) and loading it with all the ACA-Py requirements. We also load a few Visual Studio settings (for running Pytests and formatting with Ruff).

### Poetry

Expand Down
2 changes: 1 addition & 1 deletion docs/readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ version: 2
build:
os: "ubuntu-24.04"
tools:
python: "3.12"
python: "3.13"

# Build from the docs/ directory with Sphinx
sphinx:
Expand Down
Loading
Loading