feat: Remove issuance v1 protocols #3923
Open
+164
−10,060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamshale
force-pushed
the
remove-issue-credential-v1
branch
from
7ed3a9d to
d30db20
Compare
jamshale
force-pushed
the
remove-issue-credential-v1
branch
from
a5a7559 to
dec3ab4
Compare
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
jamshale
force-pushed
the
remove-issue-credential-v1
branch
from
22b5cc4 to
92401d9
Compare
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the v1 issuance protocols from ACA-Py core in favor of a plugin-based approach. The removal is part of a larger effort to modularize the codebase and allow v1 protocols to be optionally added via plugins when needed.
Key Changes:
- Complete removal of v1.0 issue credential protocol implementation
- Updates to tests and examples to use v2.0 protocols instead
- Addition of event bus handling in v2.0 routes for credential revocation
- Simplification of revocation manager by removing v1-specific logic
Reviewed changes
Copilot reviewed 56 out of 63 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scenarios/examples/connectionless/example.py | Removed v1 credential issuance example function (icv1), keeping only v2 |
| scenarios/examples/connectionless/docker-compose.yml | Changed log level from debug to info for alice and bob agents |
| acapy_agent/utils/tests/test_tracing.py | Updated imports and tests to use V20CredExRecord instead of V10CredentialExchange |
| acapy_agent/revocation/tests/test_manager.py | Updated tests to use v2 models, removed v1-specific test cases |
| acapy_agent/revocation/manager.py | Removed v1/v2 credential exchange state updates from set_cred_revoked_state method |
| acapy_agent/protocols/present_proof/v1_0/tests/test_manager.py | Updated import to use v2 credential record for state constant |
| acapy_agent/protocols/out_of_band/v1_0/tests/test_manager.py | Removed v1 credential offer tests and imports |
| acapy_agent/protocols/out_of_band/v1_0/manager.py | Removed v1 credential exchange lookup, now only supports v2 |
| acapy_agent/protocols/issue_credential/v2_0/tests/test_routes.py | Added comprehensive tests for new event bus integration |
| acapy_agent/protocols/issue_credential/v2_0/routes.py | Added register_events and cred_revoked functions for event handling |
| acapy_agent/protocols/issue_credential/v1_0/* | Deleted entire v1.0 protocol directory including routes, handlers, managers, models, messages, and all tests |
| acapy_agent/core/tests/test_goal_code_registry.py | Updated import to reference v2 CONTROLLERS instead of v1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| save_ex.assert_called_once() | ||
|
|
||
| assert ret_exchange.state == V10CredentialExchange.STATE_ABANDONED | ||
| assert ret_exchange.state == V20CredExRecord.STATE_ABANDONED |
There was a problem hiding this comment.
Incorrect state constant used. This test is for present_proof v1.0, not issue_credential v2.0. The assertion should likely use V10PresentationExchange.STATE_ABANDONED instead of V20CredExRecord.STATE_ABANDONED.
| cred_ex_record.state = V20CredExRecord.STATE_CREDENTIAL_REVOKED | ||
| await cred_ex_record.save(txn, reason="revoke credential") | ||
| await txn.commit() | ||
| except StorageNotFoundError: |
There was a problem hiding this comment.
'except' clause does nothing but pass and there is no explanatory comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the v1 issuance protocols in favor of a plugin. See #3252 for original work.
The plugin PR openwallet-foundation/acapy-plugins#2288 uses this to re-enable v1 issuance support.
When this is finished and successful the same method will be used for the presentation v1 protocols.