openthread-br: drop luci-app-openthread, proposed for luci repo - #30096
openthread-br: drop luci-app-openthread, proposed for luci repo#30096LorbusChris wants to merge 2 commits into
Conversation
21142ed to
dad9226
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 2 new commits; both commit messages match their diffs. Three inline notes, none blocking.
Generated by Claude Code
The LuCI web interface for OpenThread Border Router is proposed for the openwrt/luci repository as luci-app-openthread (openwrt/luci#8871), following the standard convention for LuCI apps, as requested in openwrt#29791 and openthread/ot-br-posix#3431. Remove the luci-app-openthread subpackage (and its install recipe) so the UI is no longer shipped from two places. Split out of openwrt#30091 so it can be reviewed and land independently of the 2026.07.0 update. Signed-off-by: Christian Glombek <c.glombek@cosa.systems> Assisted-By: Claude Fable 5
dad9226 to
300b53e
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 2 new commits; no new issues found.
The only new content since dad9226 is the README.md "### LuCI" hunk, which resolves the earlier nit — test.sh and the Makefile are byte-identical to what was already reviewed. Both commit messages still match their diffs, and the three FormalityCheck runs on 300b53e are green.
Generated by Claude Code
75b6565 to
fabe4a6
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit (300b53e → fabe4a6, the test.sh commit amended to also add test-version.sh). The amended commit message matches its diff.
The only new content since the last review is net/openthread-br/test-version.sh; test.sh, the Makefile and README.md are unchanged from what was already reviewed. One inline note on the new file. All three FormalityCheck runs on fabe4a6 are green.
Generated by Claude Code
The generic test requires some installed executable to print PKG_VERSION,
and none of this package's binaries can: otbr-agent reports the upstream
CMake project version, while PKG_VERSION is derived from PKG_SOURCE_DATE
and the source commit, which appears nowhere in the binaries. So the
generic test fails on the package as it stands:
openthread-br: No executables in the package provided version 2025.06.12~2f3c799c
openthread-br: Generic tests failed
Add a test.sh that exercises the binaries instead, which also covers their
runtime library closure. It avoids `ot-ctl --version`, which segfaults
because ot-ctl's getopt_long() option array lacks its terminating entry;
that is fixed upstream in openthread/openthread#13423.
That alone does not fix the job: CI runs the generic tests forced, so they
run even when a package-specific test.sh exists, and the version check
still fails. Add a test-version.sh, which the test harness uses in place of
that check, as alsa-lib and avahi already do for the same reason.
Signed-off-by: Christian Glombek <c.glombek@cosa.systems>
Assisted-By: Claude Opus 5
fabe4a6 to
03936f7
Compare
📦 Package Details
Maintainer: @stintel
Description
Removes the
luci-app-openthreadsubpackage fromnet/openthread-br. The LuCIweb interface is proposed for the openwrt/luci repository as
luci-app-openthread(openwrt/luci#8871), following the standard convention forLuCI apps, as requested in #29791 and openthread/ot-br-posix#3431. Dropping it
here means the UI is no longer shipped from two places.
Split out of #30091 at @stintel's request so it can be reviewed and land
independently of the 2026.07.0 update. #30091 now contains the version update,
the switch to OpenThread's internal mDNS, and the REST listen-address option, and
will be rebased on this.
PKG_RELEASEis bumped since the package contents change without a versionchange.
Note the app being removed is the old Lua/
luci-lua-runtimeimplementation; theopenwrt/luci proposal is a rewrite using the modern client-side JS + rpcd ucode
conventions, so this is not a straight move of the same files.
openwrt/luci#8871 is still open, so this should ideally land together with (or
after) it, otherwise there is a window with no OpenThread web UI available at all.
The in-tree copy in ot-br-posix is proposed for removal separately in
openthread/ot-br-posix#3326 (draft).
🧪 Run Testing Details
Removal only — no code changes to the
openthread-brpackage itself, and theremaining
Package/openthread-brrecipe is untouched. Apart frompatches/102-openwrt-fix-LuCI-icons.patch, which only rewrites icon paths insidethose same
src/openwrt/view/files, the removedPackage/luci-app-openthreadand its install recipe were the only users of the LuCI parts of the
src/openwrt/tree. The rest of that tree stays in use:src/openwrt/ubus/builds the
otbrubus object that the netifd proto handler waits on(
ubus -t30 wait_for otbr, thenubus call otbr threadstart), so-DOTBR_OPENWRT=ONis untouched here and must stay.The icon patch is left in place here; #30091 drops it, since the 2026.07.0 tag
already carries the fix upstream.
A
test.shis added in a second commit. The generic test requires an installedexecutable to print
PKG_VERSION, which none of this package's binaries do —otbr-agentreports the upstream CMake project version instead. That alreadyfails on master, independently of this change:
The test exercises
otbr-agent --versionandot-ctl -hinstead, which alsocovers their runtime library closure. It deliberately avoids
ot-ctl --version,which segfaults on an unterminated
getopt_long()option array — fixed upstreamin openthread/openthread#13423.
✅ Formalities