Conversation
Phase 1/7 of OPRUN-4738: remove object-controller's dependency on operator-controller's internal metadata package. Move the label constants into internal/shared/labels and update imports in both controllers and their tests. Generalize the object-controller comments to describe owners rather than ClusterExtensions. Review focus: the package move and mechanical import changes. Metadata keys and reconciliation behavior are unchanged. No generated files. Refs: OPRUN-4738 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Add a dedicated manager with a ClusterObjectSet-only scheme and regression coverage. Reuse referenced Secret reads within each reconciliation, retry transient read failures, and show numeric revision status when no bundle version is present. Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Add object-controller to local and Linux builds, Docker image creation, KIND loading, and multi-architecture GoReleaser output. Refs: OPRUN-4774 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
1 participant
Description
Build and package the standalone
object-controllerintroduced by #2947. The Makefile now builds its binary for the local platform and Linux, builds and loads its container image alongside operator-controller and catalogd, and passes its image repository to GoReleaser. GoReleaser includes the binary and container image for amd64, arm64, ppc64le, and s390x.This is OPRUN-4774, a subtask of OPRUN-4738. It depends on #2947, which depends on #2946. These smaller PRs replace the broad review in #2938. Deployment activation and install helpers follow in OPRUN-4775.
The PR targets
main, so its file list includes prerequisite commits until those PRs merge. Review this PR's three-file delta on the fork.Validation
make go-build-localbuilt operator-controller, catalogd, and object-controller.make docker-build IMAGE_TAG=oprun-4774-reviewbuilt the three Linux binaries and images; the manifest policy checks passed.--help.checkandmake verifypassed. The non-amd64 images were validated through configuration, not built locally.Reviewer Checklist
Always review AI generated responses prior to use.
AI-assisted response via openshift-developer plugin