Skip to content

[Onboarding] Small change to check for duplicates #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregv merged 1 commit into from
Jul 23, 2026
Merged

[Onboarding] Small change to check for duplicates #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions services/onboarding_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,19 @@ def save_onboarding_feedback(json_data):
contact_info = json_data.get("contactForFollowup", {})
client_info = json_data.get("clientInfo", {})

has_contact_info = (
contact_info.get("name") and
contact_info.get("email") and
contact_info.get("name").strip() and
contact_info.get("email").strip()
)
# The frontend sends firstName (never name) — see FeedbackSection.js.
contact_name = (contact_info.get("firstName") or contact_info.get("name") or "").strip()
contact_email = (contact_info.get("email") or "").strip()
has_contact_info = bool(contact_name and contact_email)

existing_feedback = None

if has_contact_info:
logger.info("Searching for existing feedback by contact info")
existing_docs = db.collection('onboarding_feedbacks').where(
"contactForFollowup.name", "==", contact_info["name"]
"contactForFollowup.firstName", "==", contact_name
).where(
"contactForFollowup.email", "==", contact_info["email"]
"contactForFollowup.email", "==", contact_email
).limit(1).stream()

for doc in existing_docs:
Expand Down
Loading