Skip to content

Upgrade ty and cleanup rules #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogenstad merged 1 commit into from
Dec 22, 2025
Merged

Upgrade ty and cleanup rules #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
with:
version: "${{ needs.prepare-environment.outputs.UV_VERSION }}"
- name: Install dependencies
run: uv sync --group lint
run: uv sync --all-groups --all-extras
- name: "Linting: ruff check"
run: "uv run ruff check ."
- name: "Linting: ruff format"
Expand Down
18 changes: 7 additions & 11 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ lint = [
"mypy==1.11.2",
"ruff==0.14.5",
"astroid>=3.1,<4.0",
"ty==0.0.4",
"ty==0.0.5",
]
types = [
"types-ujson",
Expand Down Expand Up @@ -130,23 +130,20 @@ include = ["infrahub_sdk/**"]
# The ignored rules below should be removed once the code has been updated, they are included #
# like this so that we can reactivate them one by one. #
##################################################################################################
division-by-zero = "ignore"
invalid-argument-type = "ignore"
invalid-assignment = "ignore"
invalid-await = "ignore"
invalid-return-type = "ignore"
invalid-type-form = "ignore"
missing-argument = "ignore"
no-matching-overload = "ignore"
possibly-unresolved-reference = "ignore"
redundant-cast = "ignore"
too-many-positional-arguments = "ignore"
type-assertion-failure = "ignore"
unknown-argument = "ignore"
unresolved-attribute = "ignore"
unresolved-import = "ignore"
unsupported-operator = "ignore"

[[tool.ty.overrides]]
include = ["infrahub_sdk/ctl/config.py"]

[tool.ty.overrides.rules]
unresolved-import = "ignore" # import tomli as tomllib when running on later versions of Python
Comment on lines +141 to +145
Copy link

@coderabbitai coderabbitai bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

cat -n infrahub_sdk/ctl/config.py | head -40

Repository: opsmill/infrahub-sdk-python

Length of output: 1468

Clarify the misleading comment in the unresolved-import override.

The comment states "import tomli as tomllib when running on later versions of Python," but this is backwards. tomllib is available in Python 3.11+, and tomli is needed for earlier versions. Update the comment to reflect: # tomli needed for Python < 3.11. The unresolved-import bypass itself is justified since the code uses the standard version-check pattern and type checkers have documented limitations with conditional imports.

🤖 Prompt for AI Agents 
In pyproject.toml around lines 141 to 145, the inline comment on the
unresolved-import override is misleading; change the comment to state that tomli
is needed for Python < 3.11 (e.g. "# tomli needed for Python < 3.11") to
accurately reflect that tomllib is the stdlib in Python 3.11+ and tomli is used
on earlier versions, leaving the override itself unchanged.



[[tool.ty.overrides]]
include = ["tests/**"]
Expand All @@ -165,7 +162,6 @@ non-subscriptable = "ignore"
not-iterable = "ignore"
possibly-missing-attribute = "ignore"
unresolved-attribute = "ignore"
unresolved-import = "ignore"


[[tool.ty.overrides]]
Expand Down
46 changes: 23 additions & 23 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.