Skip to content

Conversation

@petercrocker
Copy link
Contributor

  • Remove documentation file filter from documentation job
  • Run invoke docs.generate on every CI run, not just when docs files change
  • Update markdownlint configuration with improved formatting and comments

- Remove documentation file filter from documentation job
- Run invoke docs.generate on every CI run, not just when docs files change
- Update markdownlint configuration with improved formatting and comments
@petercrocker petercrocker linked an issue Jan 28, 2026 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2026

Deploying schema-library with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c7c76d
Status: ✅  Deploy successful!
Preview URL: https://8a08e395.schema-library.pages.dev
Branch Preview URL: https://ci-run-docs-generation-on-al.schema-library.pages.dev

View logs

id: push
run: |
git config --global user.name "documentator"
git config --global user.email "[email protected]"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe [email protected] instead?

@@ -1,5 +1,22 @@
---
# yamllint disable rule:truthy rule:truthy rule:line-length

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably bit excessive to have this inline comment, but no big deal

@petercrocker
Copy link
Contributor Author

@fatih-acar could use your £0.02 if this is a good approach in the CI pipeline of how to regenerate the docs when someone changes a schema in this repo, and push those docs file changes as part of the CI pipeline run?

@fatih-acar
Copy link

@fatih-acar could use your £0.02 if this is a good approach in the CI pipeline of how to regenerate the docs when someone changes a schema in this repo, and push those docs file changes as part of the CI pipeline run?

I don't like this pattern (we already have it in other places... I know). I think it's better to have a job that generates the docs and checks if there are diffs, then fail the job if there are any and let the human commit the generated docs instead?

It avoids wild commits from bots with random tokens (and we tend to forget about the bot commits at some point).
It can also be error prone if you merge the PR before the bot actually commits the changes in the branch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust documentation

4 participants