Skip to content

Add sort arugment for the search API #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add sort arugment for the search API #4865

wants to merge 6 commits into from

Conversation

@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Oct 2, 2025 •
edited
Loading

Fixes #4740

@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Oct 2, 2025

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 2, 2025
@gaborbernat gaborbernat mentioned this pull request Oct 2, 2025
Open
@vladak
Copy link
Member

vladak commented Oct 14, 2025

The Apirary documentation in the apiary.apib file needs update for the /search endpoint.

@vladak
Copy link
Member

vladak commented Oct 14, 2025

Also, needs a test case.

@vladak
Copy link
Member

vladak commented Oct 14, 2025

Just a note: this conflicts with the changes done for Lucene 9.x update in PR #4867. It looks like this can be reconciled easily, though.

@gaborbernat
Copy link
Contributor Author

gaborbernat commented Oct 14, 2025

I signed the OCA on Friday any idea when it will be approved?

@gaborbernat gaborbernat force-pushed the 4740-feat branch 10 times, most recently from 41ef174 to db9f5fa Compare October 16, 2025 02:39
@gaborbernat gaborbernat requested a review from vladak October 16, 2025 02:39
@gaborbernat gaborbernat force-pushed the 4740-feat branch 3 times, most recently from 35d7af4 to 8fd284e Compare October 16, 2025 14:25
@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Oct 16, 2025

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 16, 2025
@gaborbernat
Copy link
Contributor Author

gaborbernat commented Oct 16, 2025

@vladak when you can please take another look, thanks!

@vladak
Copy link
Member

vladak commented Oct 21, 2025

@vladak when you can please take another look, thanks!

The failing tests need to be fixed first.

@gaborbernat
Allow sorting in the API calls by path and date
64a232d 
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat
Add test
f23d77f 
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat
Fix apiary
389d766 
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat
Fix test
496bf62 
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat
Copy link
Contributor Author

gaborbernat commented Nov 7, 2025

@vladak can you take another look please? Thanks!

@vladak
Copy link
Member

vladak commented Nov 14, 2025 •
edited
Loading

In general this looks good; I will go through the test code in a little bit more detail before approving, though.

In the meantime you might want to add copyrights to the changed files.

@gaborbernat
PR Feedback
982b4db 
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat force-pushed the 4740-feat branch 4 times, most recently from 3a087ce to 851c7b4 Compare November 17, 2025 15:49
@gaborbernat
Copy link
Contributor Author

gaborbernat commented Nov 17, 2025

In the meantime you might want to add copyrights to the changed files.

@vladak Not sure I understand what you mean here, but addressed the other feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladak vladak vladak left review comments

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search API allow sort by path

2 participants

@gaborbernat @vladak