[Lua]vector and matrix operator overloading#641
Open
TheGondos wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks the Lua vector and matrix types to add support for operator overloading.
It tries as much as possible to stay compatible with the older way of using tables as vectors/matrices, and as a result is a bit complicated (the lua_tovector and lua_tomatrix functions now return a pointer to the userdata, but need an additional buffer parameter as a fallback in case they are called on an older table representation).
Even if the vec/mat libraries can take both types as parameters, they now always return a userdata.
To construct a vector, the easiest way is to use the existing _V function, similar as the C++ API: vec = _V(x,y,z)
Similarly for matrices, there is an existing _M function that's been upgraded.
You can now enjoy using operator overloads to simplify you programs :