Conversation
biodranik
force-pushed
the
ab/cycling-style
branch
from
August 15, 2026 07:52
9b34d53 to
acd56ad
Compare
biodranik
force-pushed
the
ab/cycling-style
branch
from
August 16, 2026 14:55
acd56ad to
4dddf9b
Compare
strump
approved these changes
Aug 17, 2026
biodranik
force-pushed
the
ab/cycling-style
branch
from
August 20, 2026 10:22
4dddf9b to
0172cf4
Compare
biodranik
changed the title
biodranik
force-pushed
the
ab/cycling-style
branch
from
September 7, 2026 21:22
43dd03b to
d3dad02
Compare
biodranik
changed the title
The main repo gained a fourth style family, so full_drules_gen.py covered only six of its eight variants. Derive the style and variant matrix from tuples so every family is covered. Keep Vehicle last because each style rewrites visibility.txt and classificator.txt and the apps ship the Vehicle outputs. Signed-off-by: Alexander Borsuk <me@alex.bio>
Honor casing-linecap on automatic casings, resolve casing-width-add when a line has its own width, and report unsupported line caps and joins as validation errors. Treat a zero shield font size as suppression of an inherited shield and reject negative sizes during generation. Existing styles remain unchanged except that Cycling no longer serializes its intentionally suppressed z10-14 motorway shields. Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
ab/cycling-style
branch
from
September 15, 2026 22:11
d3dad02 to
93559bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to organicmaps/organicmaps#13330.
Summary
casing-linecapandcasing-width-addon automatic casings and validate line cap/join values.shield-font-size: 0as suppression of an inherited shield and reject negative sizes during generation.The casing changes are also required by organicmaps/organicmaps#13463.
Testing
python3 -m unittest discover -s tests— 57/57, repeated with stable fixture outputruff check --target-version=py39