test/api/azure.sh cloud cleaning fixes #4943
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The P in IP should be uppercase. :/
ondrejbudai
requested review from
mvo5 and
supakeen
and removed request for
a team
ondrejbudai
dismissed stale reviews from supakeen and croissanne
via
75473bb
ondrejbudai
force-pushed
the
fix-azure
branch
from
d7957a6 to
75473bb
Compare
Member
Author
|
ugh, I had to convince shellcheck that using sed is fine. |
supakeen
previously approved these changes
Nov 24, 2025
The comment mentioned that vnets are re-used between tests but that's clearly not true as we use unique names for them. Let's clean them up as well so we don't have to rely on cloud-cleaner as a fallback.
ondrejbudai
force-pushed
the
fix-azure
branch
from
75473bb to
0248ac2
Compare
Member
Author
|
From https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/12194791914: 🎉 |
lzap
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/api/azure.sh: fix public IP address clean up
The P in IP should be uppercase. :/
test/api/azure.sh: delete vnets too
The comment mentioned that vnets are re-used between tests but that's
clearly not true as we use unique names for them. Let's clean them up
as well so we don't have to rely on cloud-cleaner as a fallback.