-
Notifications
You must be signed in to change notification settings - Fork 16
feat: multi-source Layer4 implementation (for discussion) #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpower432
wants to merge
5
commits into
ossf:main
Choose a base branch
from
jpower432:feat/layer4-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Documenting some feedback discussed with @eddie-knight:
|
8221cff to
98eae49
Compare
Contributor
Author
|
Temporarily converting to draft while working through feedback |
Layer 4 currently breaks the pattern established by the other layers. This add a top-level documentation that can be passed into Layer 5 for full context to execute an enforcement action. Introduce support for multiple assessment executors (tools/manual methods) that can execute assessment procedures, with configurable conflict resolution strategies when multiple executors provide results. Signed-off-by: Jennifer Power <[email protected]>
Adding confidence to EvaluationLog allows an evaluation to return a confidence level in the result based on inputs Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Assisted by: Cursor Agent Signed-off-by: Jennifer Power <[email protected]>
The finding specificiation details how to use the EvaluationPlan and deconfliction strategies to determine findings for Layer5 action. Assisted by: Cursor Agent Signed-off-by: Jennifer Power <[email protected]>
dfa34ea to
5644994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for multiple assessment evaluators in Layer 4 Evaluation Plans, enabling tools and manual methods to execute assessment procedures with configurable conflict resolution strategies when multiple evaluators provide results. This add a new directory
specto documentation how to use the Layer 4 schema for finding determination (how it could be used by Layer 5 tools). This PR precedes Layer 5 to ensure Layer 5 tools can form an opinion about the returned result.Schema Changes
Schema Changes Made
schemas/layer-1.cue) changesschemas/layer-2.cue) changesschemas/layer-3.cue) changesschemas/layer-4.cue) changesSchema Change Details
Fields Added:
Evaluators- Introducing anEvaluatorconcept that can represent both automated tools and manual review processes.Confidence Level- Allow Layer4 tools to attach confidence level to a specific result in theAssessmentLogEvaluationDocument- Adds a new top-level object to represent Layer 4EvaluationDocumentto ensure the pattern is consistent for each layer.ConflictResolution- Providing three distinct strategies that user can choose based on their security posture and tool maturityField Modified:
AssessmentPlan- Add optional conflict resolution between proceduresEvaluation Plan- Added required evaluatorsAssessmentLog- Added optional confidence levelAssessmentProcedures- Added required evaluator mappingField Removed:
None
Consumer Impact: The new
evaluatorfields in Evaluation Plan are requirement making this change not backward compatible.Testing
Run
cue vet -d "#EvaluationDocument" -s schemas/layer-4.cue layer4/test-data/multi-tool-plan.yamlRelated Issues
Partially resolves #170
Closes #175
Reviewer Hints
The new
multi-tool-plan.yamltest data demonstrates configuring multiple executors with different roles and conflict resolution strategies: