Skip to content

AO3-7565 On Fulfilled Claims page, "Fulfilled Claims" button doesn't appear pressed #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScottVenkataraman wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −5
Open

AO3-7565 On Fulfilled Claims page, "Fulfilled Claims" button doesn't appear pressed #5966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7973c0a
AO3-7565 Fix Fulfilled Claims button not showing as actively pressed
ScottVenkataraman Aug 4, 2026
fdda8d1
Update syntax for Ruby 1.9 hash syntax (remove => and replace with :)
ScottVenkataraman Aug 4, 2026
b5cd1d0
Update file to use Rails built-in 't' helper instead of 'ts'
ScottVenkataraman Aug 4, 2026
60a2b99
Remove 'role' from ul, remove 'id' from the two li within ul
ScottVenkataraman Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/views/challenge_claims/_user_index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

<!--subnav-->
<% unless params[:for_user] %>
<ul class="navigation actions" role="navigation">
<li id="unposted-link">
<%= span_if_current ts("Unfulfilled Claims"), user_claims_path(current_user), params[:posted].blank? %>
<ul class="navigation actions">
<li>
<%= span_if_current t(".navigation.unfulfilled"), user_claims_path(current_user), params[:posted].blank? %>
</li>
<li id="posted-link">
<%= span_if_current ts("Fulfilled Claims"), user_claims_path(current_user, :posted => true) %>
<li>
<%= span_if_current t(".navigation.fulfilled"), user_claims_path(current_user, posted: true), params[:posted].present? %>
</li>
</ul>

@sarken sarken Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a second, this closing tag needs to move left 2 spaces to align with the opening <ul>. But it's not blocking, so I will mark this approved!

<% end %>
Expand Down
3 changes: 3 additions & 0 deletions config/locales/views/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,9 @@ en:
user_index:
assignments: My Assignments
assignments_note_html: Looking for assignments you were given for a gift exchange? Try %{assignments_link}.
navigation:
fulfilled: Fulfilled Claims
unfulfilled: Unfulfilled Claims
challenge_signups:
signup_form:
notice:
Expand Down
Loading