Repository navigation
Add Linux aarch64 releases and fix Pages artifact recovery - #238
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 8
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8028cd8b2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add Linux ARM64 to the shared release matrix on a native Ubuntu 22.04 ARM runner. The tarball includes the GUI, daemon, CLI and Linux desktop installer, following the existing platform naming and packaging. PRs now exercise the production native build matrix with read-only permissions, verify archive contents, executable formats, CPU architecture and modes, and run the packaged CLI help command on each native runner.
Fix the Pages recovery failure in run 37649799287 by retaining the bundle for 14 days and failing on an empty upload. The successful build uploaded artifact 11500576222 on October 7 with one-day retention; the failed Publish rerun on October 9 attempted to download that expired artifact. Main is still 153c4e3, and its producer/consumer names match. Document that recovery after expiry requires re-running all jobs. Draft PRs build without deploying a Pages preview.
Closes #237.
Validation so far: git diff --check; Python compilation; synthetic ARM64 archive accepted and mislabeled x86_64 ELF rejected. actionlint reports only the existing SC2129 style warning in nightly.yml. CI will validate real binaries on native runners; the laptop has not built or executed ARM64 binaries. CLI help is a startup smoke test, not GUI or WhatsApp session coverage. No release publication, deployment or merge requested by this PR.
The draft preview gate also handles ready_for_review and converted_to_draft events. All publication and cleanup retry checks read the live PR draft boolean, including the compensating cleanup after a publication. The Codex finding about draft transitions has been corrected and its thread resolved.
Additional local validation: xtask formatting, clippy with warnings denied, and all 50 xtask tests pass. Archive rejection checks cover missing daemon, wrong CPU, nonexecutable members and a truncated gzip trailer; PE x86_64 and Mach-O ARM64 CPU checks were also exercised. On a33f67e, all six ordinary CI checks have passed; real release builds and final review remain in progress.