Admin Portal v2 theme tokens, plus two fixes to existing portal docs - #344
Open
Wictorgirardi wants to merge 1 commit into
Open
Admin Portal v2 theme tokens, plus two fixes to existing portal docs#344Wictorgirardi wants to merge 1 commit into
Wictorgirardi wants to merge 1 commit into
Conversation
Deploying phasetwo-docs with
|
| Latest commit: |
5c8432e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a30cf323.phasetwo-docs.pages.dev |
| Branch Preview URL: | https://feature-update-tokens-docs.phasetwo-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to p2-inc/phasetwo-admin-portal#199, which replaces the portal's runtime CSS-class rewriting with a pared-down set of 13 CSS-variable theme tokens stored as
_providerConfig.assets.portal.v2.<token>realm attributes. This documents the new tokens and, along the way, fixes two defects in the existing portal docs.Fixes to existing docs
1. Published attribute keys that do not work.
getting-started/customizing-ui.mdlisted the portal colors as_providerConfig.assets.portal.primary100,…primary200, and so on. The server readsprimaryColor100,primaryColor200, … — theColorinfix was missing from all nine keys, so every one of them was dead. Anyone who followed that table got no styling at all. Corrected againstPortalResourceProvider.java.2. A table that never rendered. The visibility-flag table in
admin-portal/access-control.mdhad data rows but no header or delimiter row, so GFM rendered it as literal pipe-separated text rather than a table. Given a proper header.New content
admin-portal/configuration.mdmutedandbordertokens have no effect in dark mode (those surfaces are mixed fromdarkBackground), and the foreground tokens fall back in two different ways —primaryForeground/ctaForeground/darkCtaForegroundalways auto-contrast, whileforeground/darkForegroundkeep their defaults unless you set their background explicitly.primaryColor700(fallback forprimary) andsecondaryColor900(fallback forcta) still affect rendering.:::cautionbreaking-change callout: CSS targeting the old generated utility classes (.bg-primary-700,.bg-primary-gradient, …) no longer applies, and realms that customizedprimaryColor100/primaryColor900will see neutral surfaces until they set the matchingv2tokens.admin-portal/access-control.mdorg.attributes.enabledflag (new in add logos #199) and theprofile.passwordless.enabledflag, which the server has always honored but was never documented anywhere.view-organizationto view,manage-organizationto edit.trueenables a section;TRUE,1andyesdisable it ("true".equals(v)).getting-started/customizing-ui.md