Skip to content

add create-setup-script.sh for env - #48

Open
Orangezzt wants to merge 1 commit into
p4lang:mainfrom
Orangezzt:add-setup-script
Open

add create-setup-script.sh for env#48
Orangezzt wants to merge 1 commit into
p4lang:mainfrom
Orangezzt:add-setup-script

Conversation

@Orangezzt

Copy link
Copy Markdown

add create-setup-script.sh and call it in install.sh and batch-install.sh

…l.sh

Signed-off-by: Zutao Zhang <orangetao@foxmail.com>
@jafingerhut

Copy link
Copy Markdown
Contributor

Sorry for the confusion, and having several PRs open still that are waiting to be merged, but note that if #38 is merged, it will remove the batch-install.sh script, and change the instructions in the top level README as well to no longer mention batch-install.sh.

It might be prudent to wait a bit and see whether that PR is approved and merged, and then we can decide how to proceed with your ideas.

Alternately, if we think that PR should be abandoned or modified signficantly, we can revisit this PR and see what should be done.

@Orangezzt

Copy link
Copy Markdown
Author

@jafingerhut Thank you for taking the time to explain the situation regarding the PRs. I appreciate your clear - cut communication. I'm more than happy to wait and see how PR#38 progresses. If there's any information or assistance I can provide during this waiting period, please don't hesitate to let me know. I'm looking forward to the next steps and contributing to the project in the best way possible.

@jafingerhut

Copy link
Copy Markdown
Contributor

#38 is merged now. Please take a look at it and see if there is anything else in this PR that remains you would like to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants