Skip to content

Add initialize method to InternetChecksum#1267

Open
p-sawicki wants to merge 1 commit into
p4lang:mainfrom
p-sawicki:add-initialize-to-internet-checksum
Open

Add initialize method to InternetChecksum#1267
p-sawicki wants to merge 1 commit into
p4lang:mainfrom
p-sawicki:add-initialize-to-internet-checksum

Conversation

@p-sawicki

Copy link
Copy Markdown

I would like to propose adding a new method to the InternetChecksum extern which would initialize the incremental checksum computation with the initial checksum value extracted from a header.

The motivation behind the method is that currently to achieve this, one needs to call the subtract method which may not be obvious to someone not familiar with the exact formula used for computation so a separate method with a more obvious name would be helpful. Another name considered for this method is preload.

Implementation will be simple because in compilers that already support PSA's interface, ck.initialize(chksum); can be transformed to ck.clear(); ck.subtract(chksum);

@jafingerhut jafingerhut left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants