fix: use amend commit on gh-pages to prevent unbounded repo growth#1408
Open
Devansh-567 wants to merge 1 commit into
Open
fix: use amend commit on gh-pages to prevent unbounded repo growth#1408Devansh-567 wants to merge 1 commit into
Devansh-567 wants to merge 1 commit into
Conversation
Devansh-567
force-pushed
the
fix/gh-pages-amend-commit
branch
from
May 15, 2026 08:23
bd731fc to
470ea5f
Compare
Signed-off-by: GitHub Actions <p4lang@users.noreply.github.com> Signed-off-by: Devansh Singh <devansh.jay.singh@gmail.com>
Devansh-567
force-pushed
the
fix/gh-pages-amend-commit
branch
from
May 15, 2026 08:28
470ea5f to
94d9230
Compare
Collaborator
|
Thanks for the submission. It would take me a fair amount of learning about Github Actions to review this carefully, which I may do if no one else is able to give this a proper review in the next week or two. |
Contributor
Author
|
Hi @jafingerhut, just checking in on this PR. I know GitHub Actions changes can take some time to review, so no rush. Whenever you or someone else gets a chance to look at it, I'd be happy to address any feedback or make any needed changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the deploy job adds a new commit to
gh-pageson every specchange, causing the.gitdirectory to grow unboundedly over time.This adopts the same approach used in the
p4runtimerepository:EndBug/add-and-commit@v9withcommit: '--amend'and force push, keepinggh-pagespermanently at a single commit regardless of how many times the spec is regenerated.Also simplifies the deploy job by removing the manual git rebase steps, which are no longer needed since the action handles branch management internally.
Suggested by @jafingerhut in #1403.