Added client encoding to adapted SQL parameters.#159
Open
osvill wants to merge 3 commits into
Open
Conversation
Owner
|
This is an awesome start. Would it be possible to run a test that raises the encoding error so we can verify the reverse circumstance here? |
…cute_sql. It now raises ValueError if client_encoding does not match the database encoding.
Author
|
It is hard to catch the error as a specific encoding error. I ended up adding a keyword argument |
Author
|
I ran some more tests and got errors for adapted parameters that do not have the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix & test for #158 .