-
Notifications
You must be signed in to change notification settings - Fork 13
EditableSlider UI/UX improvements #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 78.52% 78.53%
=======================================
Files 31 31
Lines 2938 2939 +1
=======================================
+ Hits 2307 2308 +1
Misses 631 631 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
That explains, would welcome a PR. |
|
Checking I think there is already a PR taking care of fixing the |
|
Note: Seems to me that the failing tests here are not related with the changes done but let me know if I should take a closer look to them! |
Fixes #484
Example code
A preview
Notes
While I was commiting this, although the pre-commit hook didn't show any error/did any fix, tested runningWorked on PR chore: Update pre-commit and fixes #502pixi run pre-commit-runand some style errors overNumberInput.jsxwhere shown/fixed. Checking the README of the pre-commit eslint hook (https://github.com/pre-commit/mirrors-eslint) seems like by default it only checks.jsfiles so maybe there is a need to config the eslint hook explicitly to check instead for.jsxfiles? 🤔 If a PR fixing that is required let me know!