Add signal handling for graceful shutdown and cleanup #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement SIGINT and SIGTERM signal handlers using pcntl extension - Add cleanup handler registration system for plugins - Use logger with notice level instead of direct output - Allow plugins to register cleanup handlers via getInstance() and registerCleanupHandler() - Gracefully handle cases where pcntl extension is not available 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add debug logs when cleanup handlers are registered - Add debug logs in signal handler showing registered handler count - Add debug logs during cleanup execution showing each handler call - Improve error logging with handler index information 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
namespacebrian
added a commit
to pantheon-systems/terminus-repository-plugin
that referenced
this pull request
Sep 24, 2025
- Register cleanup handler with Terminus core when site is created - Fix broken cleanup() method call to use cleanupPantheonSite() - Add debug logging for cleanup handler registration and execution - Ensure sites are properly cleaned up when interrupted by SIGINT/SIGTERM Depends on: pantheon-systems/terminus#2731 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Open
4 tasks
- Break long logger->debug() calls into multiple lines to stay under 120 character limit - Improve code readability while maintaining functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Enables pantheon-systems/terminus-repository-plugin#89