Fixes for the XBOX 360 usb control messages #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) XBOX 360 usb control messages for an interface, need the correct Interface specified. Currently this is set to a fixed value of Interface 0. This is needed for usb devices that do not have the XBOX 360 on the first Interface, and/or for usb devices that have multiple XBOX 360 Interfaces. 2) Removed the cpu_to_le16() usage from the recently added 'QUIRK_360_START' packets, as this is handled by the function usb_control_msg() and not by the user of this function. Signed-off-by: M Bakker <[email protected]>
|
With regards to point 1, I reordered the interfaces on our composite device to make the gamepad interface 0 for this very reason - it was not recognized by the xpad driver when it was an interface other than 0. So being able to support interfaces other than 0 strikes me as a valuable addition to the driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XBOX 360 usb control messages for an interface, need the correct Interface specified. Currently this is set to a fixed value of Interface 0. This is needed for usb devices that do not have the XBOX 360 on the first Interface, and/or for usb devices that have multiple XBOX 360 Interfaces.
Removed the cpu_to_le16() usage from the recently added 'QUIRK_360_START' packets, as this is handled by the function usb_control_msg() and not by the user of this function.
Signed-off-by: M Bakker [email protected]