stop Mul/DivLinearOperator converting static scalars to jax arrays#222
Merged
Conversation
Owner
|
If I'm reading this correctly then I think your changes LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realised that our psd/nsd tags weren't propagating with simple primitive multipliers, the culprit was simply
jnp.asarrayconverting scalar to jax arrays which escaped detection, usingnp.ndimworks in all cases.The one things I'm not really sure about is whether it was worth adding the unit diagonal
1 *and/ 1tests, it seems a bit niche but probably harmless. Happy to remove or keep as you prefer.The way I updated the tests to catch this is somewhat nuanced and I'd appreciate a look whenever you get a small moment (no rush on this one!).