Fix intermediate stops along trip headsign#41
Open
PatrickSteil wants to merge 5 commits intopatrickbr:masterfrom
Open
Fix intermediate stops along trip headsign#41PatrickSteil wants to merge 5 commits intopatrickbr:masterfrom
PatrickSteil wants to merge 5 commits intopatrickbr:masterfrom
Conversation
Owner
|
This seems like a useful option. I had a minor comment in my review. |
Contributor
Author
|
@patrickbr Thanks! I think you did not submit your review :) I don't see any comments? |
patrickbr
requested changes
Jan 21, 2026
Owner
Sorry, forgot to submit the review... |
Contributor
Author
|
@patrickbr could you have another look at this please? are the changes what you had in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Swiss GTFS Instance, there is a data-bug where the trip_headsign is set to the stop_name of a stop along the trip, but not the last stop. An example is this S4 (screenshot from travic.app):
The train stops at "St. Gallen", but then continues and the trip headsign is somewhat confusing (because the train left "St. Gallen", and is heading to another stop (in this case: "Rapperswil SG").
This PR fixes this, by checking whether the trip headsign matches the name of an intermediate stop along its journey, and if yes, set the orignal trip headsign as stop_headsign, and replaces the trip headsign by the name of the last stop.