Add variable distance and similarity threshold for stop reclustering#43
Open
magnusburton wants to merge 1 commit intopatrickbr:masterfrom
Open
Add variable distance and similarity threshold for stop reclustering#43magnusburton wants to merge 1 commit intopatrickbr:masterfrom
magnusburton wants to merge 1 commit intopatrickbr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new flags to make the stop reclustering thresholds configurable instead of hardcoded:
--recluster-stops-dist(default:75.0): distance threshold for stop reclustering with-E--recluster-stops-simi(default:0.55): similarity threshold for stop reclustering with-EThis allows users to tune the reclustering behaviour without recompiling.