Skip to content

Audit serialization trait implementations #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacebear21 merged 2 commits into from
Dec 31, 2025
Merged

Audit serialization trait implementations #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa68437
Audit serialization trait implementations
0xZaddyy Dec 11, 2025
9c33ef1
restore previous serde usage in payjoin
0xZaddyy Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions payjoin-ffi/src/receive/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ macro_rules! impl_save_for_transition {
};
}

#[derive(Debug, Clone, serde::Serialize, serde::Deserialize, uniffi::Object)]
#[derive(Debug, Clone, uniffi::Object)]
pub struct ReceiverSessionEvent(payjoin::receive::v2::SessionEvent);

impl From<payjoin::receive::v2::SessionEvent> for ReceiverSessionEvent {
Expand Down Expand Up @@ -385,7 +385,7 @@ impl From<ReceiverBuilder> for payjoin::receive::v2::ReceiverBuilder {
fn from(value: ReceiverBuilder) -> Self { value.0 }
}

#[derive(Clone, Debug, serde::Serialize, serde::Deserialize, uniffi::Object)]
#[derive(Clone, Debug, uniffi::Object)]
pub struct Initialized(payjoin::receive::v2::Receiver<payjoin::receive::v2::Initialized>);

impl From<Initialized> for payjoin::receive::v2::Receiver<payjoin::receive::v2::Initialized> {
Expand Down
2 changes: 1 addition & 1 deletion payjoin-ffi/src/send/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ macro_rules! impl_save_for_transition {
};
}

#[derive(uniffi::Object, Debug, Clone, serde::Serialize, serde::Deserialize)]
#[derive(uniffi::Object, Debug, Clone)]
pub struct SenderSessionEvent(payjoin::send::v2::SessionEvent);

impl From<SenderSessionEvent> for payjoin::send::v2::SessionEvent {
Expand Down
Loading