fix(plugin-cloud-storage): prevent memory leak with multiple collections (#16039)#16163
Open
deepshekhardas wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(plugin-cloud-storage): prevent memory leak with multiple collections (#16039)#16163deepshekhardas wants to merge 1 commit intopayloadcms:mainfrom
deepshekhardas wants to merge 1 commit intopayloadcms:mainfrom
Conversation
…ons (payloadcms#16039) Changed from creating one provider per collection to a single provider with a collectionsConfig map. This prevents browser memory leaks when using many collections with cloud storage. Fixes payloadcms#16039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16039 - Memory leak when using multiple collections in a cloud storage plugin
Problem
When multiple collections are used in a cloud storage plugin configuration, initClientUploads causes a memory leak that crashes the browser tab or freezes the computer.
Root Cause
Each collection was creating its own admin provider component, leading to excessive React component creation when many collections were configured.
Solution
Changed from creating one provider per collection to a single provider with a collectionsConfig map containing all collection configurations.
Changes
Testing