fix(utilities): use instanceof instead of constructor.name in formatErrors (#16050)#16164
Open
deepshekhardas wants to merge 1 commit intopayloadcms:mainfrom
Open
Conversation
…rrors (payloadcms#16050) Changed from constructor.name string comparison (broken by webpack/terser minification) to instanceof check which survives production builds. Fixes payloadcms#16050
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16050 - formatErrors drops data field from APIError in production builds due to class name minification
Problem
In production builds (Next.js 16 with webpack minification), formatErrors.ts silently drops the data field from APIError responses. This causes any feature that relies on error.data in the client (e.g., 2FA flows) to break in production while working in development.
Root Cause
formatErrors.ts uses proto.constructor.name string comparison to identify APIError and ValidationError instances. In production builds, webpack/terser mangles class names (APIError becomes 't' or 'e'), causing the check to fail.
Solution
Changed from constructor.name string comparison to instanceof check. APIError already calls Object.setPrototypeOf in its constructor (via ExtendableError), which fixes the instanceof issue referenced in TypeScript issue #13965.
Changes
Testing