fix(ui): relationship filter duplicate options when switching operators#16204
Merged
JarrodMFlesch merged 4 commits intomainfrom Apr 7, 2026
Merged
fix(ui): relationship filter duplicate options when switching operators#16204JarrodMFlesch merged 4 commits intomainfrom
JarrodMFlesch merged 4 commits intomainfrom
Conversation
The `reduceToIDs` helper in the relationship filter's optionsReducer read `option.id`, but options are created with `value` (not `id`). This meant deduplication never worked — `loadedIDs` was always an array of `undefined` values. When switching from `equals` to `is_in`, the second useEffect called `addOptionByID` for the already-loaded value, and because dedup was broken the same option was appended again. Fix: read `option.value` instead of `option.id` so existing options are correctly recognised and skipped. Fixes #15947 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: OM MISHRA <152969928+howwohmm@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: OM MISHRA <152969928+howwohmm@users.noreply.github.com>
Tests verify that ADD correctly deduplicates options by value — both for
single-relation flat lists and multi-relation grouped options.
The dedup test would fail with the original `option.id` read (always
undefined on `{ label, value }` options) and passes with `option.value ?? option.id`.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: OM MISHRA <152969928+howwohmm@users.noreply.github.com>
Tests that switching operators in the relationship filter doesn't create duplicate options in the value dropdown. Co-authored-by: OM MISHRA <152969928+howwohmm@users.noreply.github.com>
d334ab2 to
d793b8d
Compare
5 tasks
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
PatrikKozak
approved these changes
Apr 7, 2026
Contributor
|
🚀 This is included in version v3.82.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15947
Summary
reduceToIDsfunction was incorrectly usingoption.id(which doesn't exist on the Option type) instead ofoption.valuefor deduplicationTest plan
Continuation from #16029 which was from a fork of payload that was archived.
Co-authored-by: https://github.com/howwohmm