Skip to content

Fix live copy edit paragraph resizing#178

Merged
pbakaus merged 1 commit into
pbakaus:mainfrom
abdulwahabone:codex/fix-hero-live-edit-size
May 29, 2026
Merged

Fix live copy edit paragraph resizing#178
pbakaus merged 1 commit into
pbakaus:mainfrom
abdulwahabone:codex/fix-hero-live-edit-size

Conversation

@abdulwahabone
Copy link
Copy Markdown
Contributor

@abdulwahabone abdulwahabone commented May 29, 2026

Summary

  • Preserve the selected text leaf's pre-edit white-space behavior while live Edit copy is active.
  • Stop applying WebKit plaintext edit mode, which forces Chromium to render source newlines as visible line breaks and makes multi-line Astro copy grow.
  • Regenerated provider skill copies from the source runtime script.

Validation

  • Temporary Playwright repro against the homepage: failed before the fix with p.hero-rebuild-body height 107.5px -> 188.125px, passed after the fix. The repro test was removed before commit per request.
  • bun run build
  • node --test tests/live-browser-regression.test.mjs tests/live-browser-source.test.mjs
  • node --test tests/live-commit-manual-edits.test.mjs
  • bun run test

Note

Low Risk
Localized live-browser inline edit styling with restore on teardown; no auth, data, or API surface changes.

Overview
Fixes live inline copy editing so multi-line paragraphs no longer grow in height while Edit copy is active.

During enableInlineEdit, each editable row now snapshots its inline white-space, then sets style.whiteSpace from getComputedStyle so wrapping matches the element’s normal layout. webkitUserModify: read-write-plaintext-only is removed; that WebKit mode was forcing Chromium to treat source newlines as visible breaks and inflate block height (e.g. hero body copy).

disableInlineEdit restores the saved white-space instead of clearing WebKit plaintext mode. The same logic is applied across live-browser.js in the canonical skill path and regenerated provider skill copies.

Reviewed by Cursor Bugbot for commit ee536be. Bugbot is set up for automated code reviews on this repo. Configure here.

@abdulwahabone abdulwahabone requested a review from pbakaus as a code owner May 29, 2026 19:13
@abdulwahabone abdulwahabone marked this pull request as draft May 29, 2026 19:13
@abdulwahabone abdulwahabone marked this pull request as ready for review May 29, 2026 19:36
@pbakaus pbakaus merged commit e10cff3 into pbakaus:main May 29, 2026
2 checks passed
mp3wizard added a commit to mp3wizard/impeccable that referenced this pull request May 30, 2026
New upstream features:
- Remove the i- command prefix from the CLI (b913668)
- Fix live copy edit paragraph resizing (pbakaus#178)
- Lighten IMPECCABLE wordmark weight 500 → 400
- Rework Get started section: update instructions, fix layout rhythm
- Site polish: de-warm palette, refine chrome, clean up /designing (pbakaus#176)
- Drop stale Codex sidecar; rely on nested skill agents (pbakaus#173)
- Fix edit mode focus stealing (pbakaus#172)
- CLI v2.3.1/v2.3.2 changelog entries

Security findings: GHSA-p7fg-763f-g4gf (@anthropic-ai/sdk 0.81.0 transitive, Medium CVSS 4.8)
Security fixes: Added @anthropic-ai/sdk >=0.91.1 override in package.json; bun install confirms clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants