Skip to content

don't use report_memleaks with 8.5+#164

Merged
ashnazg merged 1 commit into
pear:masterfrom
remicollet:issue-report-memleaks
Jan 25, 2026
Merged

don't use report_memleaks with 8.5+#164
ashnazg merged 1 commit into
pear:masterfrom
remicollet:issue-report-memleaks

Conversation

@remicollet
Copy link
Copy Markdown
Contributor

No description provided.

@sonarqubecloud
Copy link
Copy Markdown

@remicollet
Copy link
Copy Markdown
Contributor Author

I think CI is wrong, as using system "pear" command

$ pear run-tests --ini=" -d include_path=." -q -d -r ./tests/PEAR/bug16077.phpt
Using INI settings: " -d include_path=."
Running 1 tests
FAIL Bug #16077: PEAR5::getStaticProperty does not return a reference to the property[tests/PEAR/bug16077.phpt]
========DIFF========
001- bool(true)
001+ PHP Deprecated:  PHP Startup: Directive 'report_memleaks' is deprecated in Unknown on line 0
002+ bool(true)
========DONE========

But using the local code

Without this patch

$ php scripts/pearcmd.php run-tests --ini=" -d include_path=." -q -d -r ./tests/PEAR/bug16077.phpt
Using INI settings: " -d include_path=."
Running 1 tests
FAIL Bug #16077: PEAR5::getStaticProperty does not return a reference to the property[tests/PEAR/bug16077.phpt]
========DIFF========
001- bool(true)
001+ PHP Deprecated:  PHP Startup: Directive 'report_memleaks' is deprecated in Unknown on line 0
002+ bool(true)
========DONE========

And with this patch

$ php scripts/pearcmd.php run-tests --ini=" -d include_path=." -q -d -r ./tests/PEAR/bug16077.phpt
Using INI settings: " -d include_path=."
Running 1 tests
TOTAL TIME: 00:01
1 PASSED TESTS
0 SKIPPED TESTS

@remicollet
Copy link
Copy Markdown
Contributor Author

remicollet commented Jan 21, 2026

I discovered this issue during the Fedora 44 mass rebuild (with PHP 8.5.2 and PEAR 1.10.17)

FTBS packages (don't know how long the log for old failed builds are kept online)

Using this patch in the main php-pear package, all builds are OK

@reedy reedy mentioned this pull request Jan 22, 2026
@ashnazg ashnazg self-assigned this Jan 25, 2026
@ashnazg ashnazg merged commit 103bc5e into pear:master Jan 25, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants