venue work: changes to how ampersands are parsed#120
Draft
missinglink wants to merge 1 commit intomasterfrom
Draft
venue work: changes to how ampersands are parsed#120missinglink wants to merge 1 commit intomasterfrom
missinglink wants to merge 1 commit intomasterfrom
Conversation
… preferrence for venues over intersections in some cases
Member
Author
|
one of the issues with this method is that there will be 'jitter' for partially complete inputs, eg: 'foo & bar'
(0.80) ➜ [ { venue: 'foo & bar' } ]
(0.70) ➜ [ { street: 'foo' }, { street: 'bar' } ]'foo & ba'
(0.68) ➜ [ { street: 'foo' }, { street: 'ba' } ]... although this might not be an issue in [edit] pelias/api@50c15db shows it's not an issue 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes to how ampersands are handled with a preference for venues over intersections in some cases.
The work is motivated by the parser having poor support for things like "Bar & Grill" (and venue names containing ampersands in general)
the diff looks like more changes than it really is 😄
the main difference is in
parser/AddressParser.jsthis allows us to change the behaviour of "IntersectionClassifier" to allow this exception:
making this change means that it's possible to see odd classifications such as '& grill' as a street, to resolve this I've added
not: 'PunctuationClassification'in many places to differentiate from anAlphaClassification.still a DRAFT PR for now, needs more testing before opening up for merging.