Skip to content

add library_dirs to extention#258

Closed
NxNiki wants to merge 2 commits into
pennmem:masterfrom
NxNiki:setup-conda
Closed

add library_dirs to extention#258
NxNiki wants to merge 2 commits into
pennmem:masterfrom
NxNiki:setup-conda

Conversation

@NxNiki

@NxNiki NxNiki commented Jan 10, 2025

Copy link
Copy Markdown

The current setup.py has a link error when installing ptsa in conda environments. This PR add library_dir to resolve this issue.
Tested in MacOS with M1 chip

@Riley16

Riley16 commented May 27, 2026

Copy link
Copy Markdown
Contributor

Superseded by #259, the 3.0.6 build modernization, which adds an equivalent library_dirs to the extension build (generalized to also cover conda-build's $PREFIX/$LIBRARY_PREFIX and the Windows library layout) and is verified green on the macOS CI matrix. Closing in favor of that PR.

@Riley16 Riley16 closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants