feat(multisig): import a shared account by scanning its QR code#501
Draft
yasin-ce wants to merge 1 commit into
Draft
feat(multisig): import a shared account by scanning its QR code#501yasin-ce wants to merge 1 commit into
yasin-ce wants to merge 1 commit into
Conversation
Wire the shared-account-import deeplink to a new ImportSharedAccount screen that fetches the account's participants and threshold from the backend, previews them, and hands off to the naming step. NameMultisig is generalized to name either a created or an imported shared account, and no longer blocks on duplicate names — account uniqueness is keyed on address, not name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an Import Shared Account flow. Scanning a multisig QR resolves the multisig metadata from the backend, shows version / threshold / participant addresses on a preview screen, and routes into the existing NameMultisigScreen with
importParamsso the account can be persisted without re-deriving its address. Wires the new screen into the multisig routes and the deeplink parser, and adds i18n copy.Related Issues
Checklist
Additional Notes
Crypto-feature checklist (per team convention):
version,threshold,addresses, andaddress; all four are threaded throughNameMultisigScreenand persisted.addressis currently trusted verbatim rather than derived from(version, threshold, addresses)and asserted equal.Open follow-ups before merge (raised in code review):
useNameMultisigScreen.ts(~line 105) takesimportParams.addressverbatim. Recommend deriving viagenerateMultisigAddress(version, threshold, addresses)and asserting equality before callingcreateMultisigMutationso a backend / payload inconsistency can't persist an account whoseaddressdisagrees with its own participant list.