Skip to content

Add downloadability of files #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add downloadability of files #1

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f49dae
Add debugging code for downloading files
jan-jockusch Feb 10, 2025
23d4014
Add more file types
jan-jockusch Feb 18, 2025
b924ad1
Remove excessive logging
jan-jockusch Feb 18, 2025
736531e
Add missing import
jan-jockusch Feb 18, 2025
012b19c
Make the patch minimal
jan-jockusch Feb 18, 2025
b8f223b
Fix typo
jan-jockusch Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/android/InAppBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Licensed to the Apache Software Foundation (ASF) under one

import android.annotation.SuppressLint;
import android.annotation.TargetApi;
import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
Expand Down Expand Up @@ -1190,6 +1189,16 @@ public boolean shouldOverrideUrlLoading(WebView webView, String url) {
@TargetApi(Build.VERSION_CODES.N)
@Override
public boolean shouldOverrideUrlLoading(WebView webView, WebResourceRequest request) {

String url = request.getUrl().toString();

if (url.matches(".*\\.(pdf|rtf|doc|docx|xls|xlsx|ppt|pptx|zip|rar|mp3|mp4|mpg|mpeg|avi|wmv|mov|apk|odt|ods|txt|csv)(\\?.*)?$")) {
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setData(Uri.parse(url));
cordova.getActivity().startActivity(intent);
return true;
}

return shouldOverrideUrlLoading(request.getUrl().toString(), request.getMethod());
}

Expand Down
Loading