Open
Conversation
* related to isDefault check of senderAddress in encode transaction * this change should have been included in perfectmak@c5cce92
…the protobuf definition change since address and path are no longer parameters
|
Thanks a million. transferCoins is working again! |
This was referenced Sep 9, 2019
suraneti
approved these changes
Sep 10, 2019
totiz
added a commit
to kulapio/libra-core
that referenced
this pull request
Sep 10, 2019
Contributor
|
Tested, work perfectly, Thanks |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined all the fixes for getAccountState(), getAccountTransaction(), and transferCoins() into one PR and closing other pull requests.
The unit test for transferring coins is re-enabled and working. This should fix #41, #42 and #45