Fix flaky test on Windows CI#2880
Merged
Merged
Conversation
Collaborator
Author
@nohwnd Thoughts? Any reason to keep some output hardcoded to milliseconds, or should I implement? |
fflaten
marked this pull request as ready for review
July 16, 2026 17:21
Member
|
We are probably already outputting human time in all the normal output, in the diag logs I am okay if it stays using just ms. Less overhead (no function call) and less complicated to write the message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixing a flaky output test because Windows might use seconds and not milliseconds.
Includes minor cleanup in output to remove whitespace between time and time suffix. Future PR should consider extracting
Get-HumanTimefromOutput.ps1toPester.Utility.ps1to get consistency.PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.