feat(server): per-client selection state storage (phux-dh4)#43
Merged
Conversation
…fecycle (phux-dh4) Implement server-side selection state management in phux-server: - Add SelectionSpan type to store selection coordinate endpoints (start/end Point) - Store spans in ServerState via HashMap<(ClientId, TerminalId), SelectionSpan> - SelectionSpan abstracts over Active (viewport) and History (scrollback) point spaces - Implement get_selection, set_selection, clear_selection methods - Clear selections on client detach (clear_client_selections) - Clear selections on terminal exit (clear_terminal_selections) - Add 11 comprehensive unit tests covering isolation, lifecycle, and edge cases Selection data is NOT stored as libghostty_vt::selection::Selection directly because Selection holds borrowed grid references that become invalid. Instead, we store the span metadata (coordinates, point space) and can reconstruct the Selection type on-demand when needed for text extraction. Test coverage: - per-terminal isolation - per-client isolation - lifecycle cleanup on detach - lifecycle cleanup on terminal exit - clearing specific selections - clearing all for client/terminal Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave A server-side selection tracking.
Commits: 5978cb3