Repository navigation
Complete errored uploads and release form loading refs - #4465
Closed
lukaszsamson wants to merge 1 commit into
Closed
lukaszsamson wants to merge 1 commit into
lukaszsamson wants to merge 1 commit into
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An errored upload entry would never complete the uploader.
EntryUploader.error()pushes error progress but never callsthis._onDone()while also removing thePHX_LIVE_FILE_UPDATEDlistener. This means a locked form with no retry.This PR addresses this by tracking failures in
this._isErroredand callingthis._onDone()plus fail fast inuploadFileswhen any of theuploader.entries()fails